From: James Morris <jmorris@namei.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Eric Paris <eparis@parisplace.org>, linux-audit@redhat.com
Subject: Re: audit-ptrace patch (untested)
Date: Wed, 7 Mar 2007 11:22:24 -0500 (EST) [thread overview]
Message-ID: <Line.LNX.4.64.0703071120470.32351@d.namei> (raw)
In-Reply-To: <1173271948.2050.17.camel@moss-spartans.epoch.ncsc.mil>
On Wed, 7 Mar 2007, Stephen Smalley wrote:
> > audit_free_aux(context);
> > kfree(context->filterkey);
> > + kfree(context->obj_ctx);
>
> Technically, this should be:
> security_release_secctx(context->obj_ctx, context->ctxlen);
> Although that does require keeping the length around, and the rest of
> the audit code is already assuming it is just a string (unlike the
> original user of these LSM hooks, the labeled IPSEC code).
I think these needs to be fixed before merge, as the presence of existing
mistakes doesn't justify adding new ones.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-03-07 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 14:50 audit-ptrace patch (untested) Alexander Viro
2007-03-06 14:46 ` Stephen Smalley
2007-03-07 3:13 ` Alexander Viro
2007-03-07 12:52 ` Stephen Smalley
2007-03-07 16:22 ` James Morris [this message]
2007-03-12 12:20 ` Alexander Viro
2007-03-12 13:07 ` Stephen Smalley
2007-03-12 14:16 ` James Morris
2007-03-12 16:19 ` Alexander Viro
2007-03-13 19:00 ` Amy Griffis
2007-03-13 19:39 ` Alexander Viro
2007-03-14 15:57 ` Amy Griffis
2007-03-14 3:06 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Line.LNX.4.64.0703071120470.32351@d.namei \
--to=jmorris@namei.org \
--cc=eparis@parisplace.org \
--cc=linux-audit@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox