From: Coly Li <i@coly.li>
To: Byungchul Park <byungchul.park@lge.com>
Cc: kent.overstreet@gmail.com, shli@kernel.org,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API
Date: Tue, 8 Aug 2017 14:50:15 +0800 [thread overview]
Message-ID: <1c3836c4-e930-5d7b-76cc-31a287a408a7@coly.li> (raw)
In-Reply-To: <20170808060056.GS20323@X58A-UD3R>
On 2017/8/8 下午2:00, Byungchul Park wrote:
> On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:
>>>>> + llist_for_each_entry_safe(cl, t, reverse, list) {
>>>>
>>>> Just wondering why not using llist_for_each_entry(), or you use the
>>>> _safe version on purpose ?
>>>
>>> If I use llist_for_each_entry(), then it would change the original
>>> behavior. Is it ok?
>>>
>>
>> I feel llist_for_each_entry() keeps the original behavior, and variable
>
> Ah.. I see. Then.. Can I change it into non-safe version? Is it still ok
> with non-safe one? I will change it at the next spin, if yes.
>
>> 't' can be removed. Anyway, either llist_for_each_entry() or
>> llist_for_each_entry_safe() works correctly and well here. Any one you
>> use is OK to me, thanks for your informative reply :-)
>
> I rather appriciate it.
>
Yes, please. And you have my Acked-by :-)
--
Coly Li
next prev parent reply other threads:[~2017-08-08 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 8:38 [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-08-07 10:18 ` Coly Li
2017-08-08 4:12 ` Byungchul Park
2017-08-08 5:28 ` Coly Li
2017-08-08 6:00 ` Byungchul Park
2017-08-08 6:50 ` Coly Li [this message]
2017-08-09 6:39 ` Nikolay Borisov
2017-08-09 6:42 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3836c4-e930-5d7b-76cc-31a287a408a7@coly.li \
--to=i@coly.li \
--cc=byungchul.park@lge.com \
--cc=kent.overstreet@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox