From: Byungchul Park <byungchul.park@lge.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Coly Li <i@coly.li>,
kent.overstreet@gmail.com, shli@kernel.org,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API
Date: Wed, 9 Aug 2017 15:42:42 +0900 [thread overview]
Message-ID: <20170809064242.GT20323@X58A-UD3R> (raw)
In-Reply-To: <aa85a3ed-d9a0-e9d6-58e2-b6c9e4a63984@suse.com>
On Wed, Aug 09, 2017 at 09:39:09AM +0300, Nikolay Borisov wrote:
>
>
> On 8.08.2017 09:00, Byungchul Park wrote:
> > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:
> >>>>> + llist_for_each_entry_safe(cl, t, reverse, list) {
> >>>>
> >>>> Just wondering why not using llist_for_each_entry(), or you use the
> >>>> _safe version on purpose ?
> >>>
> >>> If I use llist_for_each_entry(), then it would change the original
> >>> behavior. Is it ok?
>
> Generally, _safe versions of list primitives is used when you are going
> to perform removal in the iteration. I haven't looked at the code in
> bcache but if it's removing entries from the list then _safe version is
> required. If you are only iterating - then non-safe version is fine.
Thank you~ :)
prev parent reply other threads:[~2017-08-09 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 8:38 [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-08-07 10:18 ` Coly Li
2017-08-08 4:12 ` Byungchul Park
2017-08-08 5:28 ` Coly Li
2017-08-08 6:00 ` Byungchul Park
2017-08-08 6:50 ` Coly Li
2017-08-09 6:39 ` Nikolay Borisov
2017-08-09 6:42 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809064242.GT20323@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=i@coly.li \
--cc=kent.overstreet@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox