[branch: bcachefs-performance] ./include/trace/trace_events.h:327:27: error: expected expression before ‘)’ token

[branch: bcachefs-performance] ./include/trace/trace_events.h:327:27: error: expected expression before ‘)’ token

[marcin]

Hi!
I'm getting compilation error:
commit 1aae41c06651f0bffedba1a29a59afac3717d315


> In file included from ./include/trace/define_trace.h:95:0,
>                  from ./include/trace/events/bcache.h:1196,
>                  from drivers/md/bcache/trace.c:11:
> ./include/trace/events/bcache.h: In function ‘trace_raw_output_bcache_btree_bounce_block’:
> ./include/trace/trace_events.h:327:27: error: expected expression before ‘)’ token
>   trace_seq_printf(s, print);     \
>                            ^
> ./include/trace/trace_events.h:60:2: note: in expansion of macro ‘DECLARE_EVENT_CLASS’
>   DECLARE_EVENT_CLASS(name,          \
>   ^
> ./include/trace/events/bcache.h:494:1: note: in expansion of macro ‘TRACE_EVENT’
>  TRACE_EVENT(bcache_btree_bounce_block,
>  ^
> In file included from ./include/trace/define_trace.h:95:0,
>                  from ./include/trace/events/bcache.h:1196,
>                  from drivers/md/bcache/trace.c:11:
> ./include/trace/events/bcache.h: In function ‘trace_event_define_fields_bcache_btree_bounce_block’:
> ./include/trace/trace_events.h:418:32: warning: unused variable ‘field’ [-Wunused-variable]
>   struct trace_event_raw_##call field;    \
>                                 ^
> ./include/trace/trace_events.h:60:2: note: in expansion of macro ‘DECLARE_EVENT_CLASS’
>   DECLARE_EVENT_CLASS(name,          \
>   ^
> ./include/trace/events/bcache.h:494:1: note: in expansion of macro ‘TRACE_EVENT’
>  TRACE_EVENT(bcache_btree_bounce_block,
>  ^
> make[3]: *** [scripts/Makefile.build:290: drivers/md/bcache/trace.o] Błąd 1
> make[2]: *** [scripts/Makefile.build:440: drivers/md/bcache] Błąd 2
> make[1]: *** [scripts/Makefile.build:440: drivers/md] Błąd 2
> make: *** [Makefile:968: drivers] Błąd 2



gcc-5.4.0

Marcin

Re: [branch: bcachefs-performance] ./include/trace/trace_events.h:327:27: error: expected expression before ‘)’ token

[Kent Overstreet]

On Mon, Dec 05, 2016 at 10:55:24AM +0100, marcin@mejor.pl wrote:
> Hi!
> I'm getting compilation error:
> commit 1aae41c06651f0bffedba1a29a59afac3717d315

That branch has my WIP, known broken stuff :) Can you just test bcachefs-testing
for now? I'll merge those patches into bcachefs-testing soon, but for now it's
the whiteouts optimizations currently in bcachefs-testing I'm much more
concerned about.