From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-bcache@vger.kernel.org,
linux-block@vger.kernel.org
Subject: [PATCH 1/3] bcache: remove a duplicate ->make_request_fn assignment
Date: Sat, 25 Apr 2020 09:53:34 +0200 [thread overview]
Message-ID: <20200425075336.721021-2-hch@lst.de> (raw)
In-Reply-To: <20200425075336.721021-1-hch@lst.de>
The make_request_fn pointer should only be assigned by blk_alloc_queue.
Fix a left over manual initialization.
Fixes: ff27668ce809 ("bcache: pass the make_request methods to blk_queue_make_request")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/bcache/request.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 71a90fbec314b..77d1a26975174 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1372,7 +1372,6 @@ void bch_flash_dev_request_init(struct bcache_device *d)
{
struct gendisk *g = d->disk;
- g->queue->make_request_fn = flash_dev_make_request;
g->queue->backing_dev_info->congested_fn = flash_dev_congested;
d->cache_miss = flash_dev_cache_miss;
d->ioctl = flash_dev_ioctl;
--
2.26.1
next prev parent reply other threads:[~2020-04-25 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 7:53 avoid the ->make_request_fn indirect for blk-mq drivers Christoph Hellwig
2020-04-25 7:53 ` Christoph Hellwig [this message]
2020-04-25 7:53 ` [PATCH 1/3] bcache: remove a duplicate ->make_request_fn assignment Christoph Hellwig
2020-04-26 9:35 ` Coly Li
2020-04-25 7:53 ` [PATCH 2/3] dm: remove the make_request_fn check in device_area_is_invalid Christoph Hellwig
2020-04-25 7:53 ` Christoph Hellwig
2020-04-28 18:38 ` Mike Snitzer
2020-04-28 18:38 ` Mike Snitzer
2020-04-25 7:53 ` [PATCH 3/3] block: bypass ->make_request_fn for blk-mq drivers Christoph Hellwig
2020-04-25 7:53 ` Christoph Hellwig
2020-04-28 18:40 ` Mike Snitzer
2020-04-28 18:40 ` Mike Snitzer
2020-04-25 15:45 ` avoid the ->make_request_fn indirect " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425075336.721021-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox