Linux bcache driver list
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-bcache@vger.kernel.org,
	linux-block@vger.kernel.org
Subject: [PATCH 2/3] dm: remove the make_request_fn check in device_area_is_invalid
Date: Sat, 25 Apr 2020 09:53:35 +0200	[thread overview]
Message-ID: <20200425075336.721021-3-hch@lst.de> (raw)
In-Reply-To: <20200425075336.721021-1-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-table.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 0a2cc197f62b4..8277b959e00bd 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -279,7 +279,6 @@ static struct dm_dev_internal *find_device(struct list_head *l, dev_t dev)
 static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
 				  sector_t start, sector_t len, void *data)
 {
-	struct request_queue *q;
 	struct queue_limits *limits = data;
 	struct block_device *bdev = dev->bdev;
 	sector_t dev_size =
@@ -288,22 +287,6 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
 		limits->logical_block_size >> SECTOR_SHIFT;
 	char b[BDEVNAME_SIZE];
 
-	/*
-	 * Some devices exist without request functions,
-	 * such as loop devices not yet bound to backing files.
-	 * Forbid the use of such devices.
-	 */
-	q = bdev_get_queue(bdev);
-	if (!q || !q->make_request_fn) {
-		DMWARN("%s: %s is not yet initialised: "
-		       "start=%llu, len=%llu, dev_size=%llu",
-		       dm_device_name(ti->table->md), bdevname(bdev, b),
-		       (unsigned long long)start,
-		       (unsigned long long)len,
-		       (unsigned long long)dev_size);
-		return 1;
-	}
-
 	if (!dev_size)
 		return 0;
 
-- 
2.26.1

  parent reply	other threads:[~2020-04-25  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25  7:53 avoid the ->make_request_fn indirect for blk-mq drivers Christoph Hellwig
2020-04-25  7:53 ` [PATCH 1/3] bcache: remove a duplicate ->make_request_fn assignment Christoph Hellwig
2020-04-25  7:53   ` Christoph Hellwig
2020-04-26  9:35   ` Coly Li
2020-04-25  7:53 ` Christoph Hellwig [this message]
2020-04-25  7:53   ` [PATCH 2/3] dm: remove the make_request_fn check in device_area_is_invalid Christoph Hellwig
2020-04-28 18:38   ` Mike Snitzer
2020-04-28 18:38     ` Mike Snitzer
2020-04-25  7:53 ` [PATCH 3/3] block: bypass ->make_request_fn for blk-mq drivers Christoph Hellwig
2020-04-25  7:53   ` Christoph Hellwig
2020-04-28 18:40   ` Mike Snitzer
2020-04-28 18:40     ` Mike Snitzer
2020-04-25 15:45 ` avoid the ->make_request_fn indirect " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425075336.721021-3-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox