Linux bcache driver list
 help / color / mirror / Atom feed
* [PATCH] bcache: Remove dead references to cache_readaheads
@ 2023-02-25 15:33 Andrea Tomassetti
  2023-02-27 11:07 ` Coly Li
  0 siblings, 1 reply; 2+ messages in thread
From: Andrea Tomassetti @ 2023-02-25 15:33 UTC (permalink / raw)
  To: Coly Li; +Cc: Kent Overstreet, linux-bcache, Andrea Tomassetti

The cache_readaheads stat counter is not used anymore and should be
removed.

Signed-off-by: Andrea Tomassetti <andrea.tomassetti-opensource@devo.com>
---
 Documentation/admin-guide/bcache.rst | 3 ---
 drivers/md/bcache/stats.h            | 1 -
 2 files changed, 4 deletions(-)

diff --git a/Documentation/admin-guide/bcache.rst b/Documentation/admin-guide/bcache.rst
index bb5032a99234..6fdb495ac466 100644
--- a/Documentation/admin-guide/bcache.rst
+++ b/Documentation/admin-guide/bcache.rst
@@ -508,9 +508,6 @@ cache_miss_collisions
   cache miss, but raced with a write and data was already present (usually 0
   since the synchronization for cache misses was rewritten)
 
-cache_readaheads
-  Count of times readahead occurred.
-
 Sysfs - cache set
 ~~~~~~~~~~~~~~~~~
 
diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
index bd3afc856d53..21b445f8af15 100644
--- a/drivers/md/bcache/stats.h
+++ b/drivers/md/bcache/stats.h
@@ -18,7 +18,6 @@ struct cache_stats {
 	unsigned long cache_misses;
 	unsigned long cache_bypass_hits;
 	unsigned long cache_bypass_misses;
-	unsigned long cache_readaheads;
 	unsigned long cache_miss_collisions;
 	unsigned long sectors_bypassed;
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bcache: Remove dead references to cache_readaheads
  2023-02-25 15:33 [PATCH] bcache: Remove dead references to cache_readaheads Andrea Tomassetti
@ 2023-02-27 11:07 ` Coly Li
  0 siblings, 0 replies; 2+ messages in thread
From: Coly Li @ 2023-02-27 11:07 UTC (permalink / raw)
  To: Andrea Tomassetti; +Cc: Kent Overstreet, linux-bcache



> 2023年2月25日 23:33,Andrea Tomassetti <andrea.tomassetti-opensource@devo.com> 写道:
> 
> The cache_readaheads stat counter is not used anymore and should be
> removed.
> 
> Signed-off-by: Andrea Tomassetti <andrea.tomassetti-opensource@devo.com>

Nice cache, added to my for-next.

Thanks.

Coly Li



> ---
> Documentation/admin-guide/bcache.rst | 3 ---
> drivers/md/bcache/stats.h            | 1 -
> 2 files changed, 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/bcache.rst b/Documentation/admin-guide/bcache.rst
> index bb5032a99234..6fdb495ac466 100644
> --- a/Documentation/admin-guide/bcache.rst
> +++ b/Documentation/admin-guide/bcache.rst
> @@ -508,9 +508,6 @@ cache_miss_collisions
>   cache miss, but raced with a write and data was already present (usually 0
>   since the synchronization for cache misses was rewritten)
> 
> -cache_readaheads
> -  Count of times readahead occurred.
> -
> Sysfs - cache set
> ~~~~~~~~~~~~~~~~~
> 
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index bd3afc856d53..21b445f8af15 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
> unsigned long cache_misses;
> unsigned long cache_bypass_hits;
> unsigned long cache_bypass_misses;
> - unsigned long cache_readaheads;
> unsigned long cache_miss_collisions;
> unsigned long sectors_bypassed;
> 
> -- 
> 2.39.2
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-27 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-25 15:33 [PATCH] bcache: Remove dead references to cache_readaheads Andrea Tomassetti
2023-02-27 11:07 ` Coly Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox