* [PATCH v2] bcachefs: Remove obsolete comment about zstd
@ 2023-12-03 14:10 Richard Davies
2023-12-03 17:23 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Richard Davies @ 2023-12-03 14:10 UTC (permalink / raw)
To: kent.overstreet; +Cc: linux-bcachefs
Remove obsolete comment about zstd, since approach changed during
development of commit bbc3a46065d08f9ab3412b1f26bbfa778c444833
Signed-off-by: Richard Davies <richard@arachsys.com>
---
fs/bcachefs/compress.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/bcachefs/compress.c b/fs/bcachefs/compress.c
index 51af8ea..33df8cf 100644
--- a/fs/bcachefs/compress.c
+++ b/fs/bcachefs/compress.c
@@ -572,10 +572,6 @@ static int __bch2_fs_compress_init(struct bch_fs *c, u64 features)
ZSTD_parameters params = zstd_get_params(zstd_max_clevel(),
c->opts.encoded_extent_max);
- /*
- * ZSTD is lying: if we allocate the size of the workspace it says it
- * requires, it returns memory allocation errors
- */
c->zstd_workspace_size = zstd_cctx_workspace_bound(¶ms.cParams);
struct {
--
1.7.0.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] bcachefs: Remove obsolete comment about zstd
2023-12-03 14:10 [PATCH v2] bcachefs: Remove obsolete comment about zstd Richard Davies
@ 2023-12-03 17:23 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2023-12-03 17:23 UTC (permalink / raw)
To: Richard Davies; +Cc: linux-bcachefs
On Sun, Dec 03, 2023 at 02:10:27PM +0000, Richard Davies wrote:
> Remove obsolete comment about zstd, since approach changed during
> development of commit bbc3a46065d08f9ab3412b1f26bbfa778c444833
>
> Signed-off-by: Richard Davies <richard@arachsys.com>
:) Applied...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-03 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-03 14:10 [PATCH v2] bcachefs: Remove obsolete comment about zstd Richard Davies
2023-12-03 17:23 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox