* [PATCH] bcachefs: Use str_write_read() helper function
@ 2024-10-19 12:25 Thorsten Blum
2024-10-19 21:01 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-10-19 12:25 UTC (permalink / raw)
To: Kent Overstreet; +Cc: Thorsten Blum, linux-bcachefs, linux-kernel
Remove hard-coded strings by using the helper function str_write_read().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/bcachefs/journal_io.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
index 954f6a96e0f4..325c39f90f65 100644
--- a/fs/bcachefs/journal_io.c
+++ b/fs/bcachefs/journal_io.c
@@ -17,6 +17,8 @@
#include "sb-clean.h"
#include "trace.h"
+#include <linux/string_choices.h>
+
void bch2_journal_pos_from_member_info_set(struct bch_fs *c)
{
lockdep_assert_held(&c->sb_lock);
@@ -665,7 +667,7 @@ static void journal_entry_clock_to_text(struct printbuf *out, struct bch_fs *c,
struct jset_entry_clock *clock =
container_of(entry, struct jset_entry_clock, entry);
- prt_printf(out, "%s=%llu", clock->rw ? "write" : "read", le64_to_cpu(clock->time));
+ prt_printf(out, "%s=%llu", str_write_read(clock->rw), le64_to_cpu(clock->time));
}
static int journal_entry_dev_usage_validate(struct bch_fs *c,
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcachefs: Use str_write_read() helper function
2024-10-19 12:25 [PATCH] bcachefs: Use str_write_read() helper function Thorsten Blum
@ 2024-10-19 21:01 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2024-10-19 21:01 UTC (permalink / raw)
To: Thorsten Blum; +Cc: linux-bcachefs, linux-kernel
On Sat, Oct 19, 2024 at 02:25:27PM +0200, Thorsten Blum wrote:
> Remove hard-coded strings by using the helper function str_write_read().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-19 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-19 12:25 [PATCH] bcachefs: Use str_write_read() helper function Thorsten Blum
2024-10-19 21:01 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox