* [PATCH] [PATCH resend] bcachefs-tools: make targets of subvolume create/delete required
@ 2025-03-27 6:37 Integral
2025-03-27 17:58 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Integral @ 2025-03-27 6:37 UTC (permalink / raw)
To: kent.overstreet, kent.overstreet, lihongbo22
Cc: mmpgouride, linux-bcachefs, integral
Currently, when no targets are provided for "bcachefs subvolume create" or
"bcachefs subvolume delete", it will exit silently with code 0. Make targets
(arguments) required to solve this problem.
This patch solves issue https://github.com/koverstreet/bcachefs/issues/766.
Signed-off-by: Integral <integral@archlinuxcn.org>
---
src/commands/subvolume.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/commands/subvolume.rs b/src/commands/subvolume.rs
index 7df20819..6f5f2f2b 100644
--- a/src/commands/subvolume.rs
+++ b/src/commands/subvolume.rs
@@ -18,12 +18,14 @@ enum Subcommands {
#[command(visible_aliases = ["new"])]
Create {
/// Paths
+ #[arg(required = true)]
targets: Vec<PathBuf>,
},
#[command(visible_aliases = ["del"])]
Delete {
/// Path
+ #[arg(required = true)]
targets: Vec<PathBuf>,
},
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [PATCH resend] bcachefs-tools: make targets of subvolume create/delete required
2025-03-27 6:37 [PATCH] [PATCH resend] bcachefs-tools: make targets of subvolume create/delete required Integral
@ 2025-03-27 17:58 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2025-03-27 17:58 UTC (permalink / raw)
To: Integral; +Cc: kent.overstreet, lihongbo22, mmpgouride, linux-bcachefs
On Thu, Mar 27, 2025 at 02:37:19PM +0800, Integral wrote:
> Currently, when no targets are provided for "bcachefs subvolume create" or
> "bcachefs subvolume delete", it will exit silently with code 0. Make targets
> (arguments) required to solve this problem.
>
> This patch solves issue https://github.com/koverstreet/bcachefs/issues/766.
>
> Signed-off-by: Integral <integral@archlinuxcn.org>
Thanks, applied
> ---
> src/commands/subvolume.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/commands/subvolume.rs b/src/commands/subvolume.rs
> index 7df20819..6f5f2f2b 100644
> --- a/src/commands/subvolume.rs
> +++ b/src/commands/subvolume.rs
> @@ -18,12 +18,14 @@ enum Subcommands {
> #[command(visible_aliases = ["new"])]
> Create {
> /// Paths
> + #[arg(required = true)]
> targets: Vec<PathBuf>,
> },
>
> #[command(visible_aliases = ["del"])]
> Delete {
> /// Path
> + #[arg(required = true)]
> targets: Vec<PathBuf>,
> },
>
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-27 17:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-27 6:37 [PATCH] [PATCH resend] bcachefs-tools: make targets of subvolume create/delete required Integral
2025-03-27 17:58 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox