From: Shuah Khan <skhan@linuxfoundation.org>
To: Xiaxi Shen <shenxiaxi26@gmail.com>,
kent.overstreet@linux.dev, corbet@lwn.net
Cc: javier.carrasco.cruz@gmail.com,
"open list:BCACHEFS" <linux-bcachefs@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] Fix a spelling error in a doc of bcachefs
Date: Wed, 7 Aug 2024 09:42:12 -0600 [thread overview]
Message-ID: <2dfa76a7-eeae-4b05-bfcd-684ae7ade963@linuxfoundation.org> (raw)
In-Reply-To: <20240807071005.16329-1-shenxiaxi26@gmail.com>
On 8/7/24 01:10, Xiaxi Shen wrote:
Missing commit message --
> Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
> ---
> Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/bcachefs/CodingStyle.rst b/Documentation/filesystems/bcachefs/CodingStyle.rst
> index 0c45829a4899..01de555e21d8 100644
> --- a/Documentation/filesystems/bcachefs/CodingStyle.rst
> +++ b/Documentation/filesystems/bcachefs/CodingStyle.rst
> @@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
> time is being wasted because your tools are bad or too slow - don't accept it,
> fix it.
>
> -Put effort into your documentation, commmit messages, and code comments - but
> +Put effort into your documentation, commit messages, and code comments - but
> don't go overboard. A good commit message is wonderful - but if the information
> was important enough to go in a commit message, ask yourself if it would be
> even better as a code comment.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-08-07 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:10 [PATCH] Fix a spelling error in a doc of bcachefs Xiaxi Shen
2024-08-07 15:42 ` Shuah Khan [this message]
2024-08-07 16:06 ` Kent Overstreet
2024-08-07 16:36 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dfa76a7-eeae-4b05-bfcd-684ae7ade963@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenxiaxi26@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox