* [PATCH] Fix a spelling error in a doc of bcachefs
@ 2024-08-07 7:10 Xiaxi Shen
2024-08-07 15:42 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Xiaxi Shen @ 2024-08-07 7:10 UTC (permalink / raw)
To: kent.overstreet, corbet
Cc: skhan, javier.carrasco.cruz, shenxiaxi26, open list:BCACHEFS,
open list:DOCUMENTATION, open list
Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
---
Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/bcachefs/CodingStyle.rst b/Documentation/filesystems/bcachefs/CodingStyle.rst
index 0c45829a4899..01de555e21d8 100644
--- a/Documentation/filesystems/bcachefs/CodingStyle.rst
+++ b/Documentation/filesystems/bcachefs/CodingStyle.rst
@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
time is being wasted because your tools are bad or too slow - don't accept it,
fix it.
-Put effort into your documentation, commmit messages, and code comments - but
+Put effort into your documentation, commit messages, and code comments - but
don't go overboard. A good commit message is wonderful - but if the information
was important enough to go in a commit message, ask yourself if it would be
even better as a code comment.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix a spelling error in a doc of bcachefs
2024-08-07 7:10 [PATCH] Fix a spelling error in a doc of bcachefs Xiaxi Shen
@ 2024-08-07 15:42 ` Shuah Khan
2024-08-07 16:06 ` Kent Overstreet
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2024-08-07 15:42 UTC (permalink / raw)
To: Xiaxi Shen, kent.overstreet, corbet
Cc: javier.carrasco.cruz, open list:BCACHEFS, open list:DOCUMENTATION,
open list, Shuah Khan
On 8/7/24 01:10, Xiaxi Shen wrote:
Missing commit message --
> Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
> ---
> Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/bcachefs/CodingStyle.rst b/Documentation/filesystems/bcachefs/CodingStyle.rst
> index 0c45829a4899..01de555e21d8 100644
> --- a/Documentation/filesystems/bcachefs/CodingStyle.rst
> +++ b/Documentation/filesystems/bcachefs/CodingStyle.rst
> @@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
> time is being wasted because your tools are bad or too slow - don't accept it,
> fix it.
>
> -Put effort into your documentation, commmit messages, and code comments - but
> +Put effort into your documentation, commit messages, and code comments - but
> don't go overboard. A good commit message is wonderful - but if the information
> was important enough to go in a commit message, ask yourself if it would be
> even better as a code comment.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix a spelling error in a doc of bcachefs
2024-08-07 15:42 ` Shuah Khan
@ 2024-08-07 16:06 ` Kent Overstreet
2024-08-07 16:36 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Kent Overstreet @ 2024-08-07 16:06 UTC (permalink / raw)
To: Shuah Khan
Cc: Xiaxi Shen, corbet, javier.carrasco.cruz, open list:BCACHEFS,
open list:DOCUMENTATION, open list
On Wed, Aug 07, 2024 at 09:42:12AM GMT, Shuah Khan wrote:
> On 8/7/24 01:10, Xiaxi Shen wrote:
>
> Missing commit message --
I wasn't going to commit this, because I don't like taking patches that
do nothing more than fix spelling, but since it in fact does not need a
commit message for something so trivial I am applying it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix a spelling error in a doc of bcachefs
2024-08-07 16:06 ` Kent Overstreet
@ 2024-08-07 16:36 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-08-07 16:36 UTC (permalink / raw)
To: Kent Overstreet
Cc: Xiaxi Shen, corbet, javier.carrasco.cruz, open list:BCACHEFS,
open list:DOCUMENTATION, open list
On 8/7/24 10:06, Kent Overstreet wrote:
> On Wed, Aug 07, 2024 at 09:42:12AM GMT, Shuah Khan wrote:
>> On 8/7/24 01:10, Xiaxi Shen wrote:
>>
>> Missing commit message --
>
> I wasn't going to commit this, because I don't like taking patches that
> do nothing more than fix spelling, but since it in fact does not need a
> commit message for something so trivial I am applying it.
Sure. Your preference.
I don't accept patches without commit message even if it is trivial.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-07 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 7:10 [PATCH] Fix a spelling error in a doc of bcachefs Xiaxi Shen
2024-08-07 15:42 ` Shuah Khan
2024-08-07 16:06 ` Kent Overstreet
2024-08-07 16:36 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox