Linux block layer
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	chenxiang <chenxiang66@hisilicon.com>
Subject: Question on t10_pi_ref_tag()
Date: Fri, 14 Dec 2018 12:04:54 +0000	[thread overview]
Message-ID: <0336fcc8-cfc5-ab51-b2cd-3ad6b971cc8a@huawei.com> (raw)

Hi,

I have a question on this function in the $subject.

In https://marc.info/?l=linux-kernel&m=154466776014573&w=2, Martin 
recommended using this function.

However, for our driver, we find it returns 0 always, as 
rq->q->integrity.interval_exp = 0.

Our host is advertised DIF capable only. I assume that interval_exp 
would be set somehow from 
sd_dif_config_host()->blk_integrity_register(), but we don't follow this 
path for !DIX.

What would we be missing that this is unset?

Thanks,
John


             reply	other threads:[~2018-12-14 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 12:04 John Garry [this message]
2018-12-14 12:43 ` Question on t10_pi_ref_tag() Martin K. Petersen
2018-12-14 13:20   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0336fcc8-cfc5-ab51-b2cd-3ad6b971cc8a@huawei.com \
    --to=john.garry@huawei.com \
    --cc=axboe@fb.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox