* Question on t10_pi_ref_tag()
@ 2018-12-14 12:04 John Garry
2018-12-14 12:43 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: John Garry @ 2018-12-14 12:04 UTC (permalink / raw)
To: Martin K . Petersen, Christoph Hellwig, Jens Axboe
Cc: linux-scsi@vger.kernel.org, Linuxarm, linux-block@vger.kernel.org,
chenxiang
Hi,
I have a question on this function in the $subject.
In https://marc.info/?l=linux-kernel&m=154466776014573&w=2, Martin
recommended using this function.
However, for our driver, we find it returns 0 always, as
rq->q->integrity.interval_exp = 0.
Our host is advertised DIF capable only. I assume that interval_exp
would be set somehow from
sd_dif_config_host()->blk_integrity_register(), but we don't follow this
path for !DIX.
What would we be missing that this is unset?
Thanks,
John
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question on t10_pi_ref_tag()
2018-12-14 12:04 Question on t10_pi_ref_tag() John Garry
@ 2018-12-14 12:43 ` Martin K. Petersen
2018-12-14 13:20 ` John Garry
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2018-12-14 12:43 UTC (permalink / raw)
To: John Garry
Cc: Martin K . Petersen, Christoph Hellwig, Jens Axboe,
linux-scsi@vger.kernel.org, Linuxarm, linux-block@vger.kernel.org,
chenxiang
John,
> What would we be missing that this is unset?
60a89a3ce0cc scsi: t10-pi: Return correct ref tag when queue has no integrity profile
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question on t10_pi_ref_tag()
2018-12-14 12:43 ` Martin K. Petersen
@ 2018-12-14 13:20 ` John Garry
0 siblings, 0 replies; 3+ messages in thread
From: John Garry @ 2018-12-14 13:20 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Christoph Hellwig, Jens Axboe, linux-scsi@vger.kernel.org,
Linuxarm, linux-block@vger.kernel.org, chenxiang
On 14/12/2018 12:43, Martin K. Petersen wrote:
>
> John,
>
>> What would we be missing that this is unset?
>
> 60a89a3ce0cc scsi: t10-pi: Return correct ref tag when queue has no integrity profile
>
Hi Martin,
D'oh, we actually reported the issue related to this patch. But it's not
in your 4.21 queue which we were testing.
Thanks,
John
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-14 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-14 12:04 Question on t10_pi_ref_tag() John Garry
2018-12-14 12:43 ` Martin K. Petersen
2018-12-14 13:20 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox