From: Jens Axboe <axboe@kernel.dk>
To: Erics Di <zwp10758@gmail.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] blk-mq: remove double set queue_num
Date: Thu, 22 Jun 2017 08:10:38 -0600 [thread overview]
Message-ID: <05ed445c-b9a1-7bc8-511b-d915fb0e6d17@kernel.dk> (raw)
In-Reply-To: <CAA70yB4PT=uPio1owQ7AaBnZABid92ywRUcX7kzEqiTGGJJeMw@mail.gmail.com>
On 06/22/2017 03:29 AM, Erics Di wrote:
> hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need
>
> set it again.
You are right, that is a duplicate setting. But your patch is odd
in various ways:
1) Your signed-off-by and sender email (and name) have nothing to do
with each other.
2) The patch is severely mangled. How are you sending it?
#2 I can manually fix up, but I can't fix up #1.
--
Jens Axboe
next prev parent reply other threads:[~2017-06-22 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 9:29 [PATCH] blk-mq: remove double set queue_num Erics Di
2017-06-22 14:10 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-22 15:06 weiping
2017-06-22 15:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ed445c-b9a1-7bc8-511b-d915fb0e6d17@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=zwp10758@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox