Re: [PATCH 1/2] block/mq-deadline: Introduce dd_start_request()

[Damien Le Moal <dlemoal@kernel.org>]

On 2025/10/14 4:28, Bart Van Assche wrote:
> Prepare for adding a second caller of this function. No functionality
> has been changed.
> 
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Yu Kuai <yukuai@kernel.org>
> Cc: chengkaitao <chengkaitao@kylinos.cn>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

One nit below.

Other than that, looks fine to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

> ---
>  block/mq-deadline.c | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/block/mq-deadline.c b/block/mq-deadline.c
> index 3e741d33142d..647a45f6d935 100644
> --- a/block/mq-deadline.c
> +++ b/block/mq-deadline.c
> @@ -306,6 +306,19 @@ static bool started_after(struct deadline_data *dd, struct request *rq,
>  	return time_after(start_time, latest_start);
>  }
>  
> +static struct request *dd_start_request(struct deadline_data *dd,
> +					enum dd_data_dir data_dir,
> +					struct request *rq)

Why return the request that is passed ? Not sure that is necessary.


> +{
> +	u8 ioprio_class = dd_rq_ioclass(rq);
> +	enum dd_prio prio = ioprio_class_to_prio[ioprio_class];
> +
> +	dd->per_prio[prio].latest_pos[data_dir] = blk_rq_pos(rq);
> +	dd->per_prio[prio].stats.dispatched++;
> +	rq->rq_flags |= RQF_STARTED;
> +	return rq;
> +}



-- 
Damien Le Moal
Western Digital Research