From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Yu Kuai <yukuai@kernel.org>, chengkaitao <chengkaitao@kylinos.cn>
Subject: Re: [PATCH 1/2] block/mq-deadline: Introduce dd_start_request()
Date: Tue, 14 Oct 2025 08:47:50 -0700 [thread overview]
Message-ID: <7d946913-9662-44f4-b364-a4e7dc26c87a@acm.org> (raw)
In-Reply-To: <063353d7-9d79-461e-a974-4419a5b6421c@kernel.org>
On 10/13/25 9:16 PM, Damien Le Moal wrote:
> On 2025/10/14 4:28, Bart Van Assche wrote:
>> +static struct request *dd_start_request(struct deadline_data *dd,
>> + enum dd_data_dir data_dir,
>> + struct request *rq)
>
> Why return the request that is passed ? Not sure that is necessary.
If anyone wants to modify the return type of dd_start_request() into
void that's fine with me.
Thanks,
Bart.
next prev parent reply other threads:[~2025-10-14 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 19:28 [PATCH 0/2] block/mq-deadline: Fix BLK_MQ_INSERT_AT_HEAD support Bart Van Assche
2025-10-13 19:28 ` [PATCH 1/2] block/mq-deadline: Introduce dd_start_request() Bart Van Assche
2025-10-14 4:16 ` Damien Le Moal
2025-10-14 15:47 ` Bart Van Assche [this message]
2025-10-13 19:28 ` [PATCH 2/2] block/mq-deadline: Switch back to a single dispatch list Bart Van Assche
2025-10-14 4:19 ` Damien Le Moal
2025-10-14 6:10 ` Yu Kuai
2025-10-14 15:55 ` Bart Van Assche
2025-10-14 13:12 ` [PATCH 0/2] block/mq-deadline: Fix BLK_MQ_INSERT_AT_HEAD support Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d946913-9662-44f4-b364-a4e7dc26c87a@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=chengkaitao@kylinos.cn \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox