From: Daniel Wagner <dwagner@suse.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, Daniel Wagner <wagi@kernel.org>,
John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH blktests 2/3] common/rc: add _echo() function to trace sysfs attribute writes
Date: Thu, 14 May 2026 12:36:02 +0200 [thread overview]
Message-ID: <089d3a05-d001-4614-b751-b840ea8e4d0a@flourine.local> (raw)
In-Reply-To: <agWXr9Yntf4OiQ9e@shinmob>
On Thu, May 14, 2026 at 06:41:39PM +0900, Shin'ichiro Kawasaki wrote:
> Said that, this will not work when printf is used to write to
> sysfs/debugfs/configfs attributes. So, I'm tempted to Bart's idea to
> rename _echo() to _set_attr().
Indeed, my idea was to avoid prefixing all the echo with a _. Since this
doesn't work, Bart's idea to introduce explicit setters sounds like the
way to go.
next prev parent reply other threads:[~2026-05-14 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 11:23 [PATCH blktests 0/3] introduce command trace feature Shin'ichiro Kawasaki
2026-05-13 11:23 ` [PATCH blktests 1/3] check: add --cmd-trace option Shin'ichiro Kawasaki
2026-05-13 17:08 ` Bart Van Assche
2026-05-14 9:36 ` Shin'ichiro Kawasaki
2026-05-14 16:12 ` Bart Van Assche
2026-05-13 11:23 ` [PATCH blktests 2/3] common/rc: add _echo() function to trace sysfs attribute writes Shin'ichiro Kawasaki
2026-05-13 14:05 ` Daniel Wagner
2026-05-13 17:07 ` Bart Van Assche
2026-05-14 9:41 ` Shin'ichiro Kawasaki
2026-05-14 10:36 ` Daniel Wagner [this message]
2026-05-13 17:17 ` Bart Van Assche
2026-05-14 9:45 ` Shin'ichiro Kawasaki
2026-05-14 15:58 ` Bart Van Assche
2026-05-13 11:23 ` [PATCH blktests 3/3] common/nvme, nvme/rc: use _echo() " Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089d3a05-d001-4614-b751-b840ea8e4d0a@flourine.local \
--to=dwagner@suse.de \
--cc=bvanassche@acm.org \
--cc=jmeneghi@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox