Re: [PATCH blktests 1/3] check: add --cmd-trace option

[Bart Van Assche <bvanassche@acm.org>]

On 5/14/26 2:36 AM, Shin'ichiro Kawasaki wrote:
> On May 13, 2026 / 10:08, Bart Van Assche wrote:
>> On 5/13/26 4:23 AM, Shin'ichiro Kawasaki wrote:
>>> diff --git a/check b/check
>>> index c166fae..a68049b 100755
>>> --- a/check
>>> +++ b/check
>>> @@ -458,7 +458,17 @@ _call_test() {
>>>    		TIMEFORMAT="%Rs"
>>>    		pushd . >/dev/null || return
>>> +		if ((CMD_TRACE)); then
>>> +			exec 8>"${seqres}.cmdtrace"
>>> +			export BASH_XTRACEFD=8
>>> +			set -x
>>> +		fi
>>
>> Hmm ... my experience is that set -x breaks most tests.
> 
> I ran whole blktests in my test environment with this series and the --cmd-trace
> option, and observed no new failure. If the bash xtrace feature does not work in
> any environment, I would like to understand the condition.

I should have added in my email "without setting BASH_XTRACEFD". If
BASH_XTRACEFD I think that "set -x" should be fine.

Thanks,

Bart.