Linux block layer
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>,
	scott.bauer@intel.com, keith.busch@intel.com,
	jonathan.derrick@intel.com, axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically
Date: Fri, 17 Feb 2017 09:58:27 +0100	[thread overview]
Message-ID: <10ec775b-cbdc-7cac-336b-015d97c486de@suse.de> (raw)
In-Reply-To: <20170216201053.1190-2-hch@lst.de>

On 02/16/2017 09:10 PM, Christoph Hellwig wrote:
> -enum opal_response_token {
> -	OPAL_DTA_TOKENID_BYTESTRING = 0xe0,
> -	OPAL_DTA_TOKENID_SINT = 0xe1,
> -	OPAL_DTA_TOKENID_UINT = 0xe2,
> -	OPAL_DTA_TOKENID_TOKEN = 0xe3, /* actual token is returned */
> -	OPAL_DTA_TOKENID_INVALID = 0X0

Nit, here's a capital 'X' that slipped in


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  parent reply	other threads:[~2017-02-17  8:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 20:10 [PATCH 1/2] block/sed-opal: tone down not supported warnings Christoph Hellwig
2017-02-16 20:10 ` [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically Christoph Hellwig
2017-02-16 20:47   ` Scott Bauer
2017-02-17  8:58   ` Johannes Thumshirn [this message]
2017-02-17  9:11     ` Christoph Hellwig
2017-02-17  9:14       ` Johannes Thumshirn
2017-02-16 20:43 ` [PATCH 1/2] block/sed-opal: tone down not supported warnings Scott Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10ec775b-cbdc-7cac-336b-015d97c486de@suse.de \
    --to=jthumshirn@suse.de \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=jonathan.derrick@intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox