From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
scott.bauer@intel.com, keith.busch@intel.com,
jonathan.derrick@intel.com, axboe@fb.com,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically
Date: Fri, 17 Feb 2017 10:11:39 +0100 [thread overview]
Message-ID: <20170217091139.GA19393@lst.de> (raw)
In-Reply-To: <10ec775b-cbdc-7cac-336b-015d97c486de@suse.de>
On Fri, Feb 17, 2017 at 09:58:27AM +0100, Johannes Thumshirn wrote:
> On 02/16/2017 09:10 PM, Christoph Hellwig wrote:
> > -enum opal_response_token {
> > - OPAL_DTA_TOKENID_BYTESTRING = 0xe0,
> > - OPAL_DTA_TOKENID_SINT = 0xe1,
> > - OPAL_DTA_TOKENID_UINT = 0xe2,
> > - OPAL_DTA_TOKENID_TOKEN = 0xe3, /* actual token is returned */
> > - OPAL_DTA_TOKENID_INVALID = 0X0
>
> Nit, here's a capital 'X' that slipped in
I just moved the existing definition around 1:1.
next prev parent reply other threads:[~2017-02-17 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 20:10 [PATCH 1/2] block/sed-opal: tone down not supported warnings Christoph Hellwig
2017-02-16 20:10 ` [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically Christoph Hellwig
2017-02-16 20:47 ` Scott Bauer
2017-02-17 8:58 ` Johannes Thumshirn
2017-02-17 9:11 ` Christoph Hellwig [this message]
2017-02-17 9:14 ` Johannes Thumshirn
2017-02-16 20:43 ` [PATCH 1/2] block/sed-opal: tone down not supported warnings Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217091139.GA19393@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jonathan.derrick@intel.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox