From: Mike Krinkin <krinkin.m.u@gmail.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, hch@lst.de,
martin.petersen@oracle.com, hare@suse.de, shaun@tancheff.com,
damien.lemoal@hgst.com, shaun.tancheff@seagate.com,
chaitanya.kulkarni@hgst.com, Mike Krinkin <krinkin.m.u@gmail.com>
Subject: [PATCH] block: Add missed break in generic_make_request_checks
Date: Tue, 6 Dec 2016 00:18:20 +0300 [thread overview]
Message-ID: <1480972700-3873-1-git-send-email-krinkin.m.u@gmail.com> (raw)
With recent linux-next i started to get this error:
[ 19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode 4999023 at logical offset 0 with max blocks 6 with error 95
[ 19.746767] EXT4-fs (sda6): This should not happen!! Data will be lost
Bisect points at the commit e73c23ff736e ("block: add async variant of
blkdev_issue_zeroout") but i think that the real problem is a missed
break in the commit 2d253440b5af ("block: Define zoned block device
operations").
Fixes: 2d253440b5af ("block: Define zoned block device operations")
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
block/blk-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blk-core.c b/block/blk-core.c
index 24de87d..1998aa4 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1947,6 +1947,7 @@ generic_make_request_checks(struct bio *bio)
case REQ_OP_WRITE_SAME:
if (!bdev_write_same(bio->bi_bdev))
goto not_supported;
+ break;
case REQ_OP_ZONE_REPORT:
case REQ_OP_ZONE_RESET:
if (!bdev_is_zoned(bio->bi_bdev))
--
2.7.4
next reply other threads:[~2016-12-05 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 21:18 Mike Krinkin [this message]
2016-12-05 21:21 ` [PATCH] block: Add missed break in generic_make_request_checks Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480972700-3873-1-git-send-email-krinkin.m.u@gmail.com \
--to=krinkin.m.u@gmail.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@hgst.com \
--cc=damien.lemoal@hgst.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox