[PATCH] block: Add missed break in generic_make_request_checks

[PATCH] block: Add missed break in generic_make_request_checks

[Mike Krinkin]

With recent linux-next i started to get this error:

[   19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode 4999023 at logical offset 0 with max blocks 6 with error 95
[   19.746767] EXT4-fs (sda6): This should not happen!! Data will be lost

Bisect points at the commit e73c23ff736e ("block: add async variant of
blkdev_issue_zeroout") but i think that the real problem is a missed
break in the commit 2d253440b5af ("block: Define zoned block device
operations").

Fixes: 2d253440b5af ("block: Define zoned block device operations")
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
 block/blk-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-core.c b/block/blk-core.c
index 24de87d..1998aa4 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1947,6 +1947,7 @@ generic_make_request_checks(struct bio *bio)
 	case REQ_OP_WRITE_SAME:
 		if (!bdev_write_same(bio->bi_bdev))
 			goto not_supported;
+		break;
 	case REQ_OP_ZONE_REPORT:
 	case REQ_OP_ZONE_RESET:
 		if (!bdev_is_zoned(bio->bi_bdev))
-- 
2.7.4

Re: [PATCH] block: Add missed break in generic_make_request_checks

[Jens Axboe]

On 12/05/2016 02:18 PM, Mike Krinkin wrote:
> With recent linux-next i started to get this error:
> 
> [   19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode 4999023 at logical offset 0 with max blocks 6 with error 95
> [   19.746767] EXT4-fs (sda6): This should not happen!! Data will be lost
> 
> Bisect points at the commit e73c23ff736e ("block: add async variant of
> blkdev_issue_zeroout") but i think that the real problem is a missed
> break in the commit 2d253440b5af ("block: Define zoned block device
> operations").

Fix was already committed for this:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.10/block&id=58886785db318588f95c8036abb2a47016c1f14c

-- 
Jens Axboe