Linux block layer
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v4 03/11] blk-mq: introduce blk_mq_quiesce_queue_nowait()
Date: Mon, 5 Jun 2017 21:29:20 +0000	[thread overview]
Message-ID: <1496698158.2623.24.camel@sandisk.com> (raw)
In-Reply-To: <20170605155925.7896-4-ming.lei@redhat.com>

On Mon, 2017-06-05 at 23:59 +0800, Ming Lei wrote:
> This patch introduces blk_mq_quiesce_queue_nowait() so
> that we can workaround mpt3sas for quiescing its queue.
>=20
> Once mpt3sas is fixed, we can remove this helper.
>=20
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
>  include/linux/blk-mq.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 1e480015d172..13d1196f492f 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -266,6 +266,14 @@ int blk_mq_map_queues(struct blk_mq_tag_set *set);
>  void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_qu=
eues);
> =20
>  /*
> + * FIXME: this helper is just for working around mpt3sas.
> + */
> +static inline void blk_mq_quiesce_queue_nowait(struct request_queue *q)
> +{
> +	blk_mq_stop_hw_queues(q);
> +}
> +
> +/*
>   * Driver command data is immediately after the request. So subtract req=
uest
>   * size to get back to the original request, add request size to get the=
 PDU.
>   */

Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>=

  reply	other threads:[~2017-06-05 21:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 15:59 [PATCH v4 00/11] blk-mq: fix & improve queue quiescing Ming Lei
2017-06-05 15:59 ` [PATCH v4 01/11] blk-mq: fix direct issue Ming Lei
2017-06-05 21:25   ` Bart Van Assche
2017-06-06  4:21     ` Ming Lei
2017-06-05 15:59 ` [PATCH v4 02/11] blk-mq: move blk_mq_quiesce_queue() into include/linux/blk-mq.h Ming Lei
2017-06-05 15:59 ` [PATCH v4 03/11] blk-mq: introduce blk_mq_quiesce_queue_nowait() Ming Lei
2017-06-05 21:29   ` Bart Van Assche [this message]
2017-06-05 15:59 ` [PATCH v4 04/11] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-06-05 21:31   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 05/11] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-06-05 21:31   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 06/11] nvme: host: unquiesce queue in nvme_kill_queues() Ming Lei
2017-06-05 15:59 ` [PATCH v4 07/11] blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue Ming Lei
2017-06-05 21:32   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 08/11] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-06-05 15:59 ` [PATCH v4 09/11] blk-mq: don't stop queue for quiescing Ming Lei
2017-06-05 21:36   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 10/11] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-06-05 23:55   ` Bart Van Assche
2017-06-06 12:48     ` Ming Lei
2017-06-05 15:59 ` [PATCH v4 11/11] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-06-05 21:39   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496698158.2623.24.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox