Linux block layer
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v4 11/11] Revert "blk-mq: don't use sync workqueue flushing from drivers"
Date: Mon,  5 Jun 2017 23:59:25 +0800	[thread overview]
Message-ID: <20170605155925.7896-12-ming.lei@redhat.com> (raw)
In-Reply-To: <20170605155925.7896-1-ming.lei@redhat.com>

This patch reverts commit 2719aa217e0d02(blk-mq: don't use
sync workqueue flushing from drivers) because only
blk_mq_quiesce_queue() need the sync flush, and now
we don't need to stop queue any more, so revert it.

Also changes to cancel_delayed_work() in blk_mq_stop_hw_queue().

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/blk-mq.c | 30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index d3e24d600246..aa707ca75355 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -42,7 +42,6 @@ static LIST_HEAD(all_q_list);
 
 static void blk_mq_poll_stats_start(struct request_queue *q);
 static void blk_mq_poll_stats_fn(struct blk_stat_callback *cb);
-static void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync);
 
 static int blk_mq_poll_stats_bkt(const struct request *rq)
 {
@@ -1176,16 +1175,6 @@ bool blk_mq_queue_stopped(struct request_queue *q)
 }
 EXPORT_SYMBOL(blk_mq_queue_stopped);
 
-static void __blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx, bool sync)
-{
-	if (sync)
-		cancel_delayed_work_sync(&hctx->run_work);
-	else
-		cancel_delayed_work(&hctx->run_work);
-
-	set_bit(BLK_MQ_S_STOPPED, &hctx->state);
-}
-
 /*
  * We do not guarantee that dispatch can be drained or blocked
  * after blk_mq_stop_hw_queue() returns. Please use
@@ -1193,18 +1182,11 @@ static void __blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx, bool sync)
  */
 void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
 {
-	__blk_mq_stop_hw_queue(hctx, false);
-}
-EXPORT_SYMBOL(blk_mq_stop_hw_queue);
+	cancel_delayed_work(&hctx->run_work);
 
-static void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync)
-{
-	struct blk_mq_hw_ctx *hctx;
-	int i;
-
-	queue_for_each_hw_ctx(q, hctx, i)
-		__blk_mq_stop_hw_queue(hctx, sync);
+	set_bit(BLK_MQ_S_STOPPED, &hctx->state);
 }
+EXPORT_SYMBOL(blk_mq_stop_hw_queue);
 
 /*
  * We do not guarantee that dispatch can be drained or blocked
@@ -1213,7 +1195,11 @@ static void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync)
  */
 void blk_mq_stop_hw_queues(struct request_queue *q)
 {
-	__blk_mq_stop_hw_queues(q, false);
+	struct blk_mq_hw_ctx *hctx;
+	int i;
+
+	queue_for_each_hw_ctx(q, hctx, i)
+		blk_mq_stop_hw_queue(hctx);
 }
 EXPORT_SYMBOL(blk_mq_stop_hw_queues);
 
-- 
2.9.4

  parent reply	other threads:[~2017-06-05 16:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 15:59 [PATCH v4 00/11] blk-mq: fix & improve queue quiescing Ming Lei
2017-06-05 15:59 ` [PATCH v4 01/11] blk-mq: fix direct issue Ming Lei
2017-06-05 21:25   ` Bart Van Assche
2017-06-06  4:21     ` Ming Lei
2017-06-05 15:59 ` [PATCH v4 02/11] blk-mq: move blk_mq_quiesce_queue() into include/linux/blk-mq.h Ming Lei
2017-06-05 15:59 ` [PATCH v4 03/11] blk-mq: introduce blk_mq_quiesce_queue_nowait() Ming Lei
2017-06-05 21:29   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 04/11] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-06-05 21:31   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 05/11] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-06-05 21:31   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 06/11] nvme: host: unquiesce queue in nvme_kill_queues() Ming Lei
2017-06-05 15:59 ` [PATCH v4 07/11] blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue Ming Lei
2017-06-05 21:32   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 08/11] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-06-05 15:59 ` [PATCH v4 09/11] blk-mq: don't stop queue for quiescing Ming Lei
2017-06-05 21:36   ` Bart Van Assche
2017-06-05 15:59 ` [PATCH v4 10/11] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-06-05 23:55   ` Bart Van Assche
2017-06-06 12:48     ` Ming Lei
2017-06-05 15:59 ` Ming Lei [this message]
2017-06-05 21:39   ` [PATCH v4 11/11] Revert "blk-mq: don't use sync workqueue flushing from drivers" Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605155925.7896-12-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox