From: Bart Van Assche <bvanassche@acm.org>
To: Rahul Chandelkar <rc@rexion.ai>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: bsg: copy uring_cmd payload to prevent double-fetch from shared SQE
Date: Wed, 27 May 2026 09:03:35 -0700 [thread overview]
Message-ID: <155fb425-b503-44e2-bd11-444b8baeb5bb@acm.org> (raw)
In-Reply-To: <20260527105931.3950913-1-rc@rexion.ai>
On 5/27/26 3:59 AM, Rahul Chandelkar wrote:
> scsi_bsg_uring_cmd() and scsi_bsg_map_user_buffer() read bsg_uring_cmd
> fields directly from the shared mmap'd io_uring submission ring via
> io_uring_sqe128_cmd(). On the inline execution path, io_uring has not
> yet copied the SQE to kernel memory, so a concurrent userspace thread
> can modify fields between reads.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-05-27 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:59 [PATCH] scsi: bsg: copy uring_cmd payload to prevent double-fetch from shared SQE Rahul Chandelkar
2026-05-27 16:03 ` Bart Van Assche [this message]
2026-05-27 16:06 ` Jens Axboe
2026-05-27 16:19 ` Rahul Chandelkar
2026-05-27 16:27 ` Caleb Sander Mateos
2026-05-27 16:45 ` Jens Axboe
2026-05-27 16:48 ` Jens Axboe
2026-05-27 19:17 ` [PATCH v2] scsi: bsg: read io_uring command fields once Rahul Chandelkar
2026-05-30 18:02 ` Yang Xiuwei
2026-06-25 3:25 ` Yang Xiuwei
2026-06-25 12:06 ` Jens Axboe
2026-06-26 1:34 ` Yang Xiuwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155fb425-b503-44e2-bd11-444b8baeb5bb@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rc@rexion.ai \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox