From: Jens Axboe <axboe@kernel.dk>
To: Yang Xiuwei <yangxiuwei@kylinos.cn>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Rahul Chandelkar <rc@rexion.ai>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
io-uring@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Caleb Sander Mateos <csander@purestorage.com>
Subject: Re: [PATCH v2] scsi: bsg: read io_uring command fields once
Date: Thu, 25 Jun 2026 06:06:25 -0600 [thread overview]
Message-ID: <55f36cc5-a013-4960-8787-fbdf4b4d0c20@kernel.dk> (raw)
In-Reply-To: <20260626020000.0000000-1-yangxiuwei@kylinos.cn>
On 6/24/26 9:25 PM, Yang Xiuwei wrote:
> Hi James, Martin,
>
> Friendly ping on v2 ? anything else needed before pick-up?
It'll fix the issue, but it also just applies READ_ONCE() everywhere.
Which is fine, but most of them don't really matter. For example, yes
you could race on the timeout if the application is being stupid or
silly, but it doesn't matter one bit. Similarly with a bunch of others.
I'll leave that up to the SCSI folks to decide how they want to do it.
--
Jens Axboe
prev parent reply other threads:[~2026-06-25 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:59 [PATCH] scsi: bsg: copy uring_cmd payload to prevent double-fetch from shared SQE Rahul Chandelkar
2026-05-27 16:03 ` Bart Van Assche
2026-05-27 16:06 ` Jens Axboe
2026-05-27 16:19 ` Rahul Chandelkar
2026-05-27 16:27 ` Caleb Sander Mateos
2026-05-27 16:45 ` Jens Axboe
2026-05-27 16:48 ` Jens Axboe
2026-05-27 19:17 ` [PATCH v2] scsi: bsg: read io_uring command fields once Rahul Chandelkar
2026-05-30 18:02 ` Yang Xiuwei
2026-06-25 3:25 ` Yang Xiuwei
2026-06-25 12:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f36cc5-a013-4960-8787-fbdf4b4d0c20@kernel.dk \
--to=axboe@kernel.dk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=csander@purestorage.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rc@rexion.ai \
--cc=yangxiuwei@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox