From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>, Yu Kuai <yukuai3@huawei.com>,
kernel-team@fb.com,
Christopher Obbard <chris.obbard@collabora.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Saravanan D <saravanand@fb.com>
Subject: Re: [PATCH block-5.17] fix rq-qos breakage from skipping rq_qos_done_bio()
Date: Mon, 14 Mar 2022 14:23:57 -0600 [thread overview]
Message-ID: <164728943786.144850.10059816217572335500.b4-ty@kernel.dk> (raw)
In-Reply-To: <Yi7rdrzQEHjJLGKB@slm.duckdns.org>
On Sun, 13 Mar 2022 21:15:02 -1000, Tejun Heo wrote:
> a647a524a467 ("block: don't call rq_qos_ops->done_bio if the bio isn't
> tracked") made bio_endio() skip rq_qos_done_bio() if BIO_TRACKED is not set.
> While this fixed a potential oops, it also broke blk-iocost by skipping the
> done_bio callback for merged bios.
>
> Before, whether a bio goes through rq_qos_throttle() or rq_qos_merge(),
> rq_qos_done_bio() would be called on the bio on completion with BIO_TRACKED
> distinguishing the former from the latter. rq_qos_done_bio() is not called
> for bios which wenth through rq_qos_merge(). This royally confuses
> blk-iocost as the merged bios never finish and are considered perpetually
> in-flight.
>
> [...]
Applied, thanks!
[1/1] fix rq-qos breakage from skipping rq_qos_done_bio()
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-03-14 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 7:15 [PATCH block-5.17] fix rq-qos breakage from skipping rq_qos_done_bio() Tejun Heo
2022-03-14 7:58 ` Tejun Heo
2022-03-14 8:11 ` Ming Lei
2022-03-14 20:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164728943786.144850.10059816217572335500.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=chris.obbard@collabora.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=saravanand@fb.com \
--cc=tj@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox