From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org
Subject: Re: remove the bi_inline_vecs field struct bio
Date: Tue, 09 Sep 2025 07:32:16 -0600 [thread overview]
Message-ID: <175742473605.75938.8479854785092722671.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250908105653.4079264-1-hch@lst.de>
On Mon, 08 Sep 2025 12:56:37 +0200, Christoph Hellwig wrote:
> the bi_inline_vecs causes sparse to warn when a bio is embedded into a
> structure, but not the last member. This is a bit annoying but
> probably not a big. But it can be easily fixed by just removing the
> member and doing pointer arithmetics in a helper, so do that.
>
> Diffstat:
> block/bio.c | 10 +++++++---
> block/blk-crypto-fallback.c | 3 +--
> block/blk-map.c | 8 ++++----
> drivers/md/bcache/debug.c | 3 +--
> drivers/md/bcache/io.c | 3 +--
> drivers/md/bcache/journal.c | 2 +-
> drivers/md/bcache/movinggc.c | 8 ++++----
> drivers/md/bcache/super.c | 2 +-
> drivers/md/bcache/writeback.c | 8 ++++----
> drivers/md/dm-bufio.c | 2 +-
> drivers/md/dm-flakey.c | 2 +-
> drivers/md/dm-vdo/vio.c | 2 +-
> drivers/md/raid1.c | 2 +-
> drivers/md/raid10.c | 4 ++--
> drivers/target/target_core_pscsi.c | 2 +-
> fs/bcachefs/btree_io.c | 2 +-
> fs/bcachefs/data_update.h | 1 -
> fs/bcachefs/journal.c | 6 +++---
> fs/bcachefs/journal_io.c | 2 +-
> fs/bcachefs/super-io.c | 2 +-
> fs/squashfs/block.c | 2 +-
> include/linux/bio.h | 5 +++++
> include/linux/blk_types.h | 12 +++++-------
> 23 files changed, 48 insertions(+), 45 deletions(-)
>
> [...]
Applied, thanks!
[1/2] block: add a bio_init_inline helper
commit: 70a6f71b1a77decfc5b1db426ccbe914b58adb38
[2/2] block: remove the bi_inline_vecs variable sized array from struct bio
commit: d86eaa0f3c56da286853b698b45c8ce404291082
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-09-09 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 10:56 remove the bi_inline_vecs field struct bio Christoph Hellwig
2025-09-08 10:56 ` [PATCH 1/2] block: add a bio_init_inline helper Christoph Hellwig
2025-09-09 8:34 ` Yu Kuai
2025-09-09 8:43 ` John Garry
2025-09-11 6:10 ` Christoph Hellwig
2025-09-08 10:56 ` [PATCH 2/2] block: remove the bi_inline_vecs variable sized array from struct bio Christoph Hellwig
2025-09-09 8:16 ` John Garry
2025-09-09 8:40 ` Yu Kuai
2025-09-09 8:55 ` John Garry
2025-09-09 9:10 ` Yu Kuai
2025-09-11 6:12 ` Christoph Hellwig
2025-09-11 6:07 ` Christoph Hellwig
2025-09-09 13:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175742473605.75938.8479854785092722671.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox