From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: add a bio_init_inline helper
Date: Thu, 11 Sep 2025 08:10:33 +0200 [thread overview]
Message-ID: <20250911061033.GB12964@lst.de> (raw)
In-Reply-To: <b4b28858-0d55-4d98-99c8-d872e902515e@oracle.com>
On Tue, Sep 09, 2025 at 09:43:55AM +0100, John Garry wrote:
>> +static inline void bio_init_inline(struct bio *bio, struct block_device *bdev,
>> + unsigned short max_vecs, blk_opf_t opf)
>> +{
>
> I suppose that a WARN_ON(max_vecs > BIO_MAX_INLINE_VECS) could be added,
> but I don't think that we generally protect against such self-inflicted
> programming errors.
It's not needed because there isn't actually any such limit.
BIO_MAX_INLINE_VECS is misnamed and misguided. Various places in the
block layer require non-passthrough bios to not have more vectors than
BIO_MAX_VECS, while BIO_MAX_INLINE_VECS is a random upper bound for
passthrough I/O without a deeper meaning.
next prev parent reply other threads:[~2025-09-11 6:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 10:56 remove the bi_inline_vecs field struct bio Christoph Hellwig
2025-09-08 10:56 ` [PATCH 1/2] block: add a bio_init_inline helper Christoph Hellwig
2025-09-09 8:34 ` Yu Kuai
2025-09-09 8:43 ` John Garry
2025-09-11 6:10 ` Christoph Hellwig [this message]
2025-09-08 10:56 ` [PATCH 2/2] block: remove the bi_inline_vecs variable sized array from struct bio Christoph Hellwig
2025-09-09 8:16 ` John Garry
2025-09-09 8:40 ` Yu Kuai
2025-09-09 8:55 ` John Garry
2025-09-09 9:10 ` Yu Kuai
2025-09-11 6:12 ` Christoph Hellwig
2025-09-11 6:07 ` Christoph Hellwig
2025-09-09 13:32 ` remove the bi_inline_vecs field " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911061033.GB12964@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox