From: Jens Axboe <axboe@kernel.dk>
To: Lizhi Xu <lizhi.xu@windriver.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Chen <me@linux.beauty>
Cc: stable@vger.kernel.org, Markus Elfring <Markus.Elfring@web.de>,
Yang Erkun <yangerkun@huawei.com>,
Ming Lei <ming.lei@redhat.com>,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH v2] loop: fix backing file reference leak on validation error
Date: Thu, 02 Oct 2025 15:30:02 -0600 [thread overview]
Message-ID: <175944060261.1563810.3419677787520547910.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250930003559.708798-1-me@linux.beauty>
On Tue, 30 Sep 2025 08:35:59 +0800, Li Chen wrote:
> loop_change_fd() and loop_configure() call loop_check_backing_file()
> to validate the new backing file. If validation fails, the reference
> acquired by fget() was not dropped, leaking a file reference.
>
> Fix this by calling fput(file) before returning the error.
>
>
> [...]
Applied, thanks!
[1/1] loop: fix backing file reference leak on validation error
commit: 98b7bf54338b797e3a11e8178ce0e806060d8fa3
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-10-02 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 0:35 [PATCH v2] loop: fix backing file reference leak on validation error Li Chen
2025-10-02 21:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175944060261.1563810.3419677787520547910.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Markus.Elfring@web.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=me@linux.beauty \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox