public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiufei Xue <jiufei.xue@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>, tj@kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: delete unused Kconfig
Date: Tue, 21 Jul 2020 09:53:38 +0800	[thread overview]
Message-ID: <1d2dc1b4-4b62-15b0-750d-abd25d75370f@linux.alibaba.com> (raw)
In-Reply-To: <87ab9c56-74a7-8874-6373-453970a89b7f@kernel.dk>



On 2020/7/21 上午9:51, Jens Axboe wrote:
> On 7/20/20 7:50 PM, Jiufei Xue wrote:
>>
>>
>> On 2020/7/20 下午11:49, Jens Axboe wrote:
>>> On 7/20/20 2:33 AM, Jiufei Xue wrote:
>>>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
>>>> ---
>>>>  block/Kconfig | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/block/Kconfig b/block/Kconfig
>>>> index 9357d73..d52c9bc 100644
>>>> --- a/block/Kconfig
>>>> +++ b/block/Kconfig
>>>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
>>>>  config BLK_CGROUP_IOCOST
>>>>  	bool "Enable support for cost model based cgroup IO controller"
>>>>  	depends on BLK_CGROUP=y
>>>> -	select BLK_RQ_IO_DATA_LEN
>>>>  	select BLK_RQ_ALLOC_TIME
>>>>  	help
>>>>  	Enabling this option enables the .weight interface for cost
>>>
>>> What's the difference between v1 and v2? A commit message would
>>> also be nice...
>>> Sorry for the confusion. I have misspelled *unused* in patch v1.
> 
> Ah I see. Can you send a v3 that has a simple commit message at least?
> 
Of course. I will send v3 soon.

      reply	other threads:[~2020-07-21  1:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20  8:33 [PATCH v2] block: delete unused Kconfig Jiufei Xue
2020-07-20 15:49 ` Jens Axboe
2020-07-21  1:50   ` Jiufei Xue
2020-07-21  1:51     ` Jens Axboe
2020-07-21  1:53       ` Jiufei Xue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d2dc1b4-4b62-15b0-750d-abd25d75370f@linux.alibaba.com \
    --to=jiufei.xue@linux.alibaba.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox