From: Jens Axboe <axboe@kernel.dk>
To: Jiufei Xue <jiufei.xue@linux.alibaba.com>, tj@kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: delete unused Kconfig
Date: Mon, 20 Jul 2020 19:51:29 -0600 [thread overview]
Message-ID: <87ab9c56-74a7-8874-6373-453970a89b7f@kernel.dk> (raw)
In-Reply-To: <f24171eb-b1f8-746d-d379-4478ebe9ad70@linux.alibaba.com>
On 7/20/20 7:50 PM, Jiufei Xue wrote:
>
>
> On 2020/7/20 下午11:49, Jens Axboe wrote:
>> On 7/20/20 2:33 AM, Jiufei Xue wrote:
>>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
>>> ---
>>> block/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/block/Kconfig b/block/Kconfig
>>> index 9357d73..d52c9bc 100644
>>> --- a/block/Kconfig
>>> +++ b/block/Kconfig
>>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
>>> config BLK_CGROUP_IOCOST
>>> bool "Enable support for cost model based cgroup IO controller"
>>> depends on BLK_CGROUP=y
>>> - select BLK_RQ_IO_DATA_LEN
>>> select BLK_RQ_ALLOC_TIME
>>> help
>>> Enabling this option enables the .weight interface for cost
>>
>> What's the difference between v1 and v2? A commit message would
>> also be nice...
>> Sorry for the confusion. I have misspelled *unused* in patch v1.
Ah I see. Can you send a v3 that has a simple commit message at least?
--
Jens Axboe
next prev parent reply other threads:[~2020-07-21 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 8:33 [PATCH v2] block: delete unused Kconfig Jiufei Xue
2020-07-20 15:49 ` Jens Axboe
2020-07-21 1:50 ` Jiufei Xue
2020-07-21 1:51 ` Jens Axboe [this message]
2020-07-21 1:53 ` Jiufei Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab9c56-74a7-8874-6373-453970a89b7f@kernel.dk \
--to=axboe@kernel.dk \
--cc=jiufei.xue@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox