From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/2] blk-mq-debugfs: add q->mq_freeze_depth output
Date: Wed, 1 Mar 2017 19:07:33 -0800 [thread overview]
Message-ID: <20170302030733.GA7792@vader> (raw)
In-Reply-To: <6fb18656-799e-6221-6b82-44f14cd59418@fb.com>
On Wed, Mar 01, 2017 at 07:25:59PM -0700, Jens Axboe wrote:
> On 03/01/2017 11:42 AM, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > This can be used to diagnose freeze-related hangs.
>
> Do we really need this? For the loop case, it was painfully
> obvious that it was a count issue. And I can't think of any
> cases where it would have helped us, outside of rewriting
> core parts (like the first edition of the shadow requests
> for the scheduler).
>
> Not strongly opposed to it, feel free to convince me.
I don't feel a burning need for it, let's just drop it.
next prev parent reply other threads:[~2017-03-02 3:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 18:42 [PATCH 1/2] loop: fix LO_FLAGS_PARTSCAN hang Omar Sandoval
2017-03-01 18:42 ` [PATCH 2/2] blk-mq-debugfs: add q->mq_freeze_depth output Omar Sandoval
2017-03-02 2:25 ` Jens Axboe
2017-03-02 3:07 ` Omar Sandoval [this message]
2017-03-02 1:57 ` [PATCH 1/2] loop: fix LO_FLAGS_PARTSCAN hang Ming Lei
2017-03-02 2:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302030733.GA7792@vader \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox