Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>, <linux-block@vger.kernel.org>
Cc: <kernel-team@fb.com>, Ming Lei <tom.leiming@gmail.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] loop: fix LO_FLAGS_PARTSCAN hang
Date: Wed, 1 Mar 2017 19:26:48 -0700	[thread overview]
Message-ID: <c868e1be-e224-c1fa-1c32-7c73c1f7359b@fb.com> (raw)
In-Reply-To: <7e888cad9e6c35835559281d3ab9e05ea48836d0.1488393750.git.osandov@fb.com>

On 03/01/2017 11:42 AM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> loop_reread_partitions() needs to do I/O, but we just froze the queue,
> so we end up waiting forever. This can easily be reproduced with losetup
> -P. Fix it by moving the reread to after we unfreeze the queue.

Thanks Omar, applied. That's a brown paper bag bug.

-- 
Jens Axboe

      parent reply	other threads:[~2017-03-02  3:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 18:42 [PATCH 1/2] loop: fix LO_FLAGS_PARTSCAN hang Omar Sandoval
2017-03-01 18:42 ` [PATCH 2/2] blk-mq-debugfs: add q->mq_freeze_depth output Omar Sandoval
2017-03-02  2:25   ` Jens Axboe
2017-03-02  3:07     ` Omar Sandoval
2017-03-02  1:57 ` [PATCH 1/2] loop: fix LO_FLAGS_PARTSCAN hang Ming Lei
2017-03-02  2:26 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c868e1be-e224-c1fa-1c32-7c73c1f7359b@fb.com \
    --to=axboe@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@osandov.com \
    --cc=stable@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox