From: Omar Sandoval <osandov@osandov.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Karel Zak <kzak@redhat.com>,
linux-block@vger.kernel.org, kernel-team@fb.com,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 1/2] loop: always return block size in LOOP_GET_STATUS
Date: Fri, 18 Aug 2017 01:22:26 -0700 [thread overview]
Message-ID: <20170818082226.GK2459@vader> (raw)
In-Reply-To: <3a42bb8d-1850-8d6c-11c6-bf8632af5e7a@suse.de>
On Fri, Aug 18, 2017 at 10:12:51AM +0200, Hannes Reinecke wrote:
> On 08/18/2017 10:05 AM, Omar Sandoval wrote:
> > On Fri, Aug 18, 2017 at 09:56:26AM +0200, Hannes Reinecke wrote:
> >> On 08/18/2017 09:47 AM, Omar Sandoval wrote:
> [ .. ]
> >>>
> >>> I actually checked losetup, it works just fine with LO_FLAGS_BLOCKSIZE
> >>> always set and lo_init[0] always filled in.
> >>>
> >> The original argument I had with the util-linux maintainer did not
> >> revolve so much around technical details :-)
> >
> > Karel, what were your concerns here?
> >
> It wasn't Karel, it was our guy.
> Doesn't make it any better, though...
I just went through the code and util-linux doesn't mention lo_init at
all except for the definition, and everywhere it's using lo_flags would
work fine with the behavior I implemented here. Unless there's an actual
issue someone can point out, I see no reason to not do it this way.
next prev parent reply other threads:[~2017-08-18 8:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 6:15 [PATCH 0/2] loop: LOOP_FLAGS_BLOCKSIZE fixes Omar Sandoval
2017-08-18 6:15 ` [PATCH 1/2] loop: always return block size in LOOP_GET_STATUS Omar Sandoval
2017-08-18 7:18 ` Hannes Reinecke
2017-08-18 7:38 ` Omar Sandoval
2017-08-18 7:43 ` Hannes Reinecke
2017-08-18 7:47 ` Omar Sandoval
2017-08-18 7:56 ` Hannes Reinecke
2017-08-18 8:05 ` Omar Sandoval
2017-08-18 8:12 ` Hannes Reinecke
2017-08-18 8:22 ` Omar Sandoval [this message]
2017-08-18 9:22 ` Karel Zak
2017-08-18 16:44 ` Omar Sandoval
2017-08-18 17:25 ` Karel Zak
2017-08-18 9:39 ` Karel Zak
2017-08-18 6:15 ` [PATCH 2/2] loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt type Omar Sandoval
2017-08-18 7:20 ` Hannes Reinecke
2017-08-18 6:51 ` [PATCH 0/2] loop: LOOP_FLAGS_BLOCKSIZE fixes Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818082226.GK2459@vader \
--to=osandov@osandov.com \
--cc=hare@suse.de \
--cc=kernel-team@fb.com \
--cc=kzak@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox