From: Keith Busch <keith.busch@intel.com>
To: Anish M Jhaveri <anish.jhaveri@paviliondata.com>
Cc: sagi@grimberg.me, hch@lst.de, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 01/10] Initial multipath implementation.
Date: Tue, 12 Sep 2017 12:00:44 -0400 [thread overview]
Message-ID: <20170912160043.GB2832@localhost.localdomain> (raw)
In-Reply-To: <20170912042149.drr5dumro5grm7iu@haynes>
On Mon, Sep 11, 2017 at 09:21:49PM -0700, Anish M Jhaveri wrote:
> struct nvme_ctrl_ops {
> @@ -277,6 +307,7 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
> int nvme_disable_ctrl(struct nvme_ctrl *ctrl, u64 cap);
> int nvme_enable_ctrl(struct nvme_ctrl *ctrl, u64 cap);
> int nvme_shutdown_ctrl(struct nvme_ctrl *ctrl);
> +struct nvme_ctrl *nvme_init_mpath_ctrl(struct nvme_ctrl *ctrl);
> int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev,
> const struct nvme_ctrl_ops *ops, unsigned long quirks);
> void nvme_uninit_ctrl(struct nvme_ctrl *ctrl);
> @@ -287,6 +318,9 @@ int nvme_init_identify(struct nvme_ctrl *ctrl);
>
> void nvme_queue_scan(struct nvme_ctrl *ctrl);
> void nvme_remove_namespaces(struct nvme_ctrl *ctrl);
> +void nvme_trigger_failover(struct nvme_ctrl *ctrl);
> +int nvme_set_ns_active(struct nvme_ns *standby_ns, struct nvme_ns *mpath_ns,
> + int retry_cnt);
>
> int nvme_sec_submit(void *data, u16 spsp, u8 secp, void *buffer, size_t len,
> bool send);
> @@ -325,6 +359,7 @@ int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count);
> void nvme_start_keep_alive(struct nvme_ctrl *ctrl);
> void nvme_stop_keep_alive(struct nvme_ctrl *ctrl);
> int nvme_reset_ctrl(struct nvme_ctrl *ctrl);
> +void nvme_mpath_ns_remove(struct nvme_ns *ns);
>
> #ifdef CONFIG_NVM
> int nvme_nvm_ns_supported(struct nvme_ns *ns, struct nvme_id_ns *id);
I find this patch series confusing to review. You declare these failover
functions in patch 1, use them in patch 2, but they're not defined until
patch 7.
next prev parent reply other threads:[~2017-09-12 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 4:21 [PATCH 01/10] Initial multipath implementation Anish M Jhaveri
2017-09-12 16:00 ` Keith Busch [this message]
2017-09-13 5:48 ` Anish Jhaveri
2017-09-13 14:34 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912160043.GB2832@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=anish.jhaveri@paviliondata.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox