From: Keith Busch <keith.busch@intel.com>
To: Anish Jhaveri <anish.jhaveri@paviliondata.com>
Cc: sagi@grimberg.me, hch@lst.de, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 01/10] Initial multipath implementation.
Date: Wed, 13 Sep 2017 10:34:43 -0400 [thread overview]
Message-ID: <20170913143442.GE2832@localhost.localdomain> (raw)
In-Reply-To: <20170913054822.pkykbsvyh36uto5f@haynes>
On Tue, Sep 12, 2017 at 10:48:22PM -0700, Anish Jhaveri wrote:
> On Tue, Sep 12, 2017 at 12:00:44PM -0400, Keith Busch wrote:
> >
> > I find this patch series confusing to review. You declare these failover
> > functions in patch 1, use them in patch 2, but they're not defined until
> > patch 7.
> Sorry for late reply.
>
> Idea was to keep header file changes as separate patch.
> I will move the function declaration to patch 7 and
> rearrange the patch series. If you or anyone else finds
> something which could help in browsing the changes, I
> will try to incorporate next patchset.
At the very least, you don't want any patch in the series to depend
on a future patch just to compile. There are multiple breakages like
that in your series. For example, patch 5 starts a kthread at function
nvme_mpath_kthread, but that function doesn't exist until patch 8.
prev parent reply other threads:[~2017-09-13 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 4:21 [PATCH 01/10] Initial multipath implementation Anish M Jhaveri
2017-09-12 16:00 ` Keith Busch
2017-09-13 5:48 ` Anish Jhaveri
2017-09-13 14:34 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913143442.GE2832@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=anish.jhaveri@paviliondata.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox