public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	javier@cnexlabs.com, igor.j.konopko@intel.com,
	marcin.dziegielewski@intel.com,
	"Matias Bjørling" <mb@lightnvm.io>
Subject: [GIT PULL 17/18] lightnvm: pblk: add possibility to set write buffer size manually
Date: Fri,  1 Jun 2018 15:04:31 +0200	[thread overview]
Message-ID: <20180601130432.30866-18-mb@lightnvm.io> (raw)
In-Reply-To: <20180601130432.30866-1-mb@lightnvm.io>

From: Marcin Dziegielewski <marcin.dziegielewski@intel.com>

In some cases, users can want set write buffer size manually, e.g. to
adjust it to specific workload. This patch provides the possibility
to set write buffer size via module parameter feature.

Signed-off-by: Marcin Dziegielewski <marcin.dziegielewski@intel.com>
Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
 drivers/lightnvm/pblk-init.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index d65d2f972ccf..c890493e0e49 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -20,6 +20,11 @@
 
 #include "pblk.h"
 
+unsigned int write_buffer_size;
+
+module_param(write_buffer_size, uint, 0644);
+MODULE_PARM_DESC(write_buffer_size, "number of entries in a write buffer");
+
 static struct kmem_cache *pblk_ws_cache, *pblk_rec_cache, *pblk_g_rq_cache,
 				*pblk_w_rq_cache;
 static DECLARE_RWSEM(pblk_lock);
@@ -172,10 +177,15 @@ static int pblk_rwb_init(struct pblk *pblk)
 	struct nvm_tgt_dev *dev = pblk->dev;
 	struct nvm_geo *geo = &dev->geo;
 	struct pblk_rb_entry *entries;
-	unsigned long nr_entries;
+	unsigned long nr_entries, buffer_size;
 	unsigned int power_size, power_seg_sz;
 
-	nr_entries = pblk_rb_calculate_size(pblk->pgs_in_buffer);
+	if (write_buffer_size && (write_buffer_size > pblk->pgs_in_buffer))
+		buffer_size = write_buffer_size;
+	else
+		buffer_size = pblk->pgs_in_buffer;
+
+	nr_entries = pblk_rb_calculate_size(buffer_size);
 
 	entries = vzalloc(nr_entries * sizeof(struct pblk_rb_entry));
 	if (!entries)
-- 
2.11.0

  parent reply	other threads:[~2018-06-01 13:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 13:04 [GIT PULL v2 00/18] lightnvm updates for 4.18 Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 01/18] lightnvm: pblk: fail gracefully on line alloc. failure Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 02/18] lightnvm: pblk: recheck for bad lines at runtime Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 03/18] lightnvm: pblk: check read lba on gc path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 04/18] lightnvn: pblk: improve error msg on corrupted LBAs Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 05/18] lightnvm: pblk: warn in case of corrupted write buffer Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 06/18] lightnvm: pblk: return NVM_ error on failed submission Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 07/18] lightnvm: pblk: remove unnecessary indirection Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 08/18] lightnvm: pblk: remove unnecessary argument Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 09/18] lightnvm: pblk: check for chunk size before allocating it Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 10/18] lightnvn: pass flag on graceful teardown to targets Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 11/18] lightnvm: pblk: remove dead function Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 12/18] lightnvm: pblk: rework write error recovery path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 13/18] lightnvm: pblk: garbage collect lines with failed writes Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 14/18] lightnvm: pblk: fix smeta write error path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 15/18] lightnvm: proper error handling for pblk_bio_add_pages Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 16/18] lightnvm: fix partial read error path Matias Bjørling
2018-06-01 13:04 ` Matias Bjørling [this message]
2018-06-01 13:04 ` [GIT PULL 18/18] lightnvm: pblk: remove unnecessary bio_get/put Matias Bjørling
2018-06-01 13:45 ` [GIT PULL v2 00/18] lightnvm updates for 4.18 Jens Axboe
2018-06-01 14:01   ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601130432.30866-18-mb@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=axboe@fb.com \
    --cc=igor.j.konopko@intel.com \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.dziegielewski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox