public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	javier@cnexlabs.com, igor.j.konopko@intel.com,
	marcin.dziegielewski@intel.com,
	"Javier González" <javier@javigon.com>,
	"Matias Bjørling" <mb@lightnvm.io>
Subject: [GIT PULL 06/18] lightnvm: pblk: return NVM_ error on failed submission
Date: Fri,  1 Jun 2018 15:04:20 +0200	[thread overview]
Message-ID: <20180601130432.30866-7-mb@lightnvm.io> (raw)
In-Reply-To: <20180601130432.30866-1-mb@lightnvm.io>

From: Javier González <javier@javigon.com>

Return a meaningful error when the sanity vector I/O check fails.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
 drivers/lightnvm/pblk-core.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 2cad918434a7..0d4078805ecc 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -467,16 +467,13 @@ int pblk_submit_io(struct pblk *pblk, struct nvm_rq *rqd)
 {
 	struct nvm_tgt_dev *dev = pblk->dev;
 
+	atomic_inc(&pblk->inflight_io);
+
 #ifdef CONFIG_NVM_DEBUG
-	int ret;
-
-	ret = pblk_check_io(pblk, rqd);
-	if (ret)
-		return ret;
+	if (pblk_check_io(pblk, rqd))
+		return NVM_IO_ERR;
 #endif
 
-	atomic_inc(&pblk->inflight_io);
-
 	return nvm_submit_io(dev, rqd);
 }
 
@@ -484,16 +481,13 @@ int pblk_submit_io_sync(struct pblk *pblk, struct nvm_rq *rqd)
 {
 	struct nvm_tgt_dev *dev = pblk->dev;
 
+	atomic_inc(&pblk->inflight_io);
+
 #ifdef CONFIG_NVM_DEBUG
-	int ret;
-
-	ret = pblk_check_io(pblk, rqd);
-	if (ret)
-		return ret;
+	if (pblk_check_io(pblk, rqd))
+		return NVM_IO_ERR;
 #endif
 
-	atomic_inc(&pblk->inflight_io);
-
 	return nvm_submit_io_sync(dev, rqd);
 }
 
-- 
2.11.0

  parent reply	other threads:[~2018-06-01 13:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 13:04 [GIT PULL v2 00/18] lightnvm updates for 4.18 Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 01/18] lightnvm: pblk: fail gracefully on line alloc. failure Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 02/18] lightnvm: pblk: recheck for bad lines at runtime Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 03/18] lightnvm: pblk: check read lba on gc path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 04/18] lightnvn: pblk: improve error msg on corrupted LBAs Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 05/18] lightnvm: pblk: warn in case of corrupted write buffer Matias Bjørling
2018-06-01 13:04 ` Matias Bjørling [this message]
2018-06-01 13:04 ` [GIT PULL 07/18] lightnvm: pblk: remove unnecessary indirection Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 08/18] lightnvm: pblk: remove unnecessary argument Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 09/18] lightnvm: pblk: check for chunk size before allocating it Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 10/18] lightnvn: pass flag on graceful teardown to targets Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 11/18] lightnvm: pblk: remove dead function Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 12/18] lightnvm: pblk: rework write error recovery path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 13/18] lightnvm: pblk: garbage collect lines with failed writes Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 14/18] lightnvm: pblk: fix smeta write error path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 15/18] lightnvm: proper error handling for pblk_bio_add_pages Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 16/18] lightnvm: fix partial read error path Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 17/18] lightnvm: pblk: add possibility to set write buffer size manually Matias Bjørling
2018-06-01 13:04 ` [GIT PULL 18/18] lightnvm: pblk: remove unnecessary bio_get/put Matias Bjørling
2018-06-01 13:45 ` [GIT PULL v2 00/18] lightnvm updates for 4.18 Jens Axboe
2018-06-01 14:01   ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601130432.30866-7-mb@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=axboe@fb.com \
    --cc=igor.j.konopko@intel.com \
    --cc=javier@cnexlabs.com \
    --cc=javier@javigon.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.dziegielewski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox