* [PATCH] blk-mq: update nr_requests when switching to 'none' scheduler
@ 2018-06-02 7:18 Ming Lei
2018-06-02 20:08 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Ming Lei @ 2018-06-02 7:18 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Ming Lei, Marco Patalano, Ewan D. Milne
Now we setup q->nr_requests when switching to one new scheduler,
but not do it for 'none', then q->nr_requests may not be correct
for 'none'.
This patch fixes this issue by always updating 'nr_requests' when
switching to 'none'.
Cc: Marco Patalano <mpatalan@redhat.com>
Cc: "Ewan D. Milne" <emilne@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq-sched.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index b0f2c2a40a0c..b087d8884a08 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -585,6 +585,7 @@ int blk_mq_init_sched(struct request_queue *q, struct elevator_type *e)
if (!e) {
q->elevator = NULL;
+ q->nr_requests = q->tag_set->queue_depth;
return 0;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq: update nr_requests when switching to 'none' scheduler
2018-06-02 7:18 [PATCH] blk-mq: update nr_requests when switching to 'none' scheduler Ming Lei
@ 2018-06-02 20:08 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-06-02 20:08 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-block, Marco Patalano, Ewan D. Milne
On 6/2/18 1:18 AM, Ming Lei wrote:
> Now we setup q->nr_requests when switching to one new scheduler,
> but not do it for 'none', then q->nr_requests may not be correct
> for 'none'.
>
> This patch fixes this issue by always updating 'nr_requests' when
> switching to 'none'.
Looks fine, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-02 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-02 7:18 [PATCH] blk-mq: update nr_requests when switching to 'none' scheduler Ming Lei
2018-06-02 20:08 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox