public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Signed-off-by: Kitone ELvis Peter <elviskitone@gmail.com>
@ 2018-06-08  8:57 Kitone ELvis Peter
  2018-06-08 13:11 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Kitone ELvis Peter @ 2018-06-08  8:57 UTC (permalink / raw)
  To: axboe; +Cc: linux-block

Subject: REMOVE CODING STYLE ERRORS AND WARNINGS

Removed trailing spaces, used tab instead of spaces and also removed the
space between a variable and the '++' operator to improve code readability
---
 block/partitions/acorn.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/block/partitions/acorn.c b/block/partitions/acorn.c
index fbeb697..3bfe39d 100644
--- a/block/partitions/acorn.c
+++ b/block/partitions/acorn.c
@@ -79,7 +79,7 @@ static int riscix_partition(struct parsed_partitions *state,
 {
 	Sector sect;
 	struct riscix_record *rr;
-	
+
 	rr = read_part_sector(state, first_sect, &sect);
 	if (!rr)
 		return -1;
@@ -152,7 +152,7 @@ static int linux_partition(struct parsed_partitions *state,
 		put_partition(state, slot++, first_sect +
 				 le32_to_cpu(linuxp->start_sect),
 				 le32_to_cpu(linuxp->nr_sects));
-		linuxp ++;
+		linux++;
 	}
 	strlcat(state->pp_buf, " >", PAGE_SIZE);
 
@@ -269,7 +269,7 @@ int adfspart_check_ADFS(struct parsed_partitions *state)
 	dr = adfs_partition(state, "ADFS", data, 0, slot++);
 	if (!dr) {
 		put_dev_sector(sect);
-    		return 0;
+		return 0;
 	}
 
 	heads = dr->heads + ((dr->lowsector >> 6) & 1);
@@ -365,10 +365,10 @@ int adfspart_check_ICS(struct parsed_partitions *state)
 	 */
 	data = read_part_sector(state, 0, &sect);
 	if (!data)
-	    	return -1;
+		return -1;
 
 	if (!valid_ics_sector(data)) {
-	    	put_dev_sector(sect);
+		put_dev_sector(sect);
 		return 0;
 	}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] Signed-off-by: Kitone Elvis Peter <elviskitone@gmail.com>
@ 2018-06-08  9:07 Kitone Elvis Peter
  2018-06-08 13:12 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Kitone Elvis Peter @ 2018-06-08  9:07 UTC (permalink / raw)
  To: axboe; +Cc: linux-block

Subject: REMOVE DELETION ERROR

Corrected the modified variable in  previous commit
---
 block/partitions/acorn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partitions/acorn.c b/block/partitions/acorn.c
index 3bfe39d..358b05e 100644
--- a/block/partitions/acorn.c
+++ b/block/partitions/acorn.c
@@ -152,7 +152,7 @@ static int linux_partition(struct parsed_partitions *state,
 		put_partition(state, slot++, first_sect +
 				 le32_to_cpu(linuxp->start_sect),
 				 le32_to_cpu(linuxp->nr_sects));
-		linux++;
+		linuxp++;
 	}
 	strlcat(state->pp_buf, " >", PAGE_SIZE);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Signed-off-by: Kitone ELvis Peter <elviskitone@gmail.com>
  2018-06-08  8:57 [PATCH] Signed-off-by: Kitone ELvis Peter <elviskitone@gmail.com> Kitone ELvis Peter
@ 2018-06-08 13:11 ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2018-06-08 13:11 UTC (permalink / raw)
  To: Kitone ELvis Peter; +Cc: linux-block

On 6/8/18 2:57 AM, Kitone ELvis Peter wrote:
> Subject: REMOVE CODING STYLE ERRORS AND WARNINGS
> 
> Removed trailing spaces, used tab instead of spaces and also removed the
> space between a variable and the '++' operator to improve code readability

You're still messing this up. The subject line is in the message body,
the subject line contains your signed-off-by.

Please take a look at your email and reason about how to fix this up
before trying again.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Signed-off-by: Kitone Elvis Peter <elviskitone@gmail.com>
  2018-06-08  9:07 [PATCH] Signed-off-by: Kitone Elvis " Kitone Elvis Peter
@ 2018-06-08 13:12 ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2018-06-08 13:12 UTC (permalink / raw)
  To: Kitone Elvis Peter; +Cc: linux-block

On 6/8/18 3:07 AM, Kitone Elvis Peter wrote:
> Subject: REMOVE DELETION ERROR
> 
> Corrected the modified variable in  previous commit

That's not how it works - you send out a v2 of the patch instead. Read:

Documentation/process/submitting-patches.rst

and don't send anything out before you have. And never send out patches
that you haven't even compiled.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-08 13:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08  8:57 [PATCH] Signed-off-by: Kitone ELvis Peter <elviskitone@gmail.com> Kitone ELvis Peter
2018-06-08 13:11 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2018-06-08  9:07 [PATCH] Signed-off-by: Kitone Elvis " Kitone Elvis Peter
2018-06-08 13:12 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox