public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Valente <paolo.valente@linaro.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	ulf.hansson@linaro.org, linus.walleij@linaro.org,
	broonie@kernel.org, bfq-iosched@googlegroups.com,
	oleksandr@natalenko.name,
	Paolo Valente <paolo.valente@linaro.org>
Subject: [PATCH 0/1] bfq: remove prefixes from cgroup filenames
Date: Mon,  8 Apr 2019 16:39:34 +0200	[thread overview]
Message-ID: <20190408143935.9062-1-paolo.valente@linaro.org> (raw)

When bfq was merged into mainline, there were two I/O schedulers that
implemented the proportional-share policy: bfq for blk-mq and cfq for
legacy blk. bfq's interface files in the blkio/io controller have the
same names as cfq. But the cgroups interface doesn't allow two
entities to use the same name for their files, so for bfq we had to
prepend the "bfq" prefix to each of its files. However no legacy code
uses these modified file names. This naming also causes confusion, as,
e.g., in [1].

So we tried to propose a solution to enable entities to share
interface files for identical parameters [2]. But our solution didn't
convince Tejun, and we got stuck.

Fortunately, now cfq has gone with legacy blk, so there is no need any
longer for prefixes in (the never used) bfq names. In view of this
fact, here's an alternative patch, which simply removes these
prefixes, thereby enabling legacy code to truly use the proportional
share policy in blk-mq. This postpones the problem of sharing common
interface files, to when, e.g., some new proportional-share policy
gets proposed.

Paolo

[1] https://github.com/systemd/systemd/issues/7057
[2] https://lwn.net/ml/linux-block/20181119103424.3853-1-paolo.valente@linaro.org/

Angelo Ruocco (1):
  block, bfq: delete "bfq" prefix from cgroup filenames

 block/bfq-cgroup.c | 46 +++++++++++++++++++++++-----------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

--
2.20.1

             reply	other threads:[~2019-04-08 14:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 14:39 Paolo Valente [this message]
2019-04-08 14:39 ` [PATCH 1/1] block, bfq: delete "bfq" prefix from cgroup filenames Paolo Valente
2019-04-08 14:49   ` Johannes Thumshirn
2019-04-08 14:54     ` Paolo Valente
2019-04-08 15:01       ` Jens Axboe
2019-04-08 15:04       ` Johannes Thumshirn
2019-04-08 15:05         ` Jens Axboe
2019-04-08 15:06           ` Paolo Valente
2019-04-08 15:11             ` Jens Axboe
2019-04-08 15:15               ` Paolo Valente
2019-04-08 15:08           ` Johannes Thumshirn
2019-04-08 15:13             ` Jens Axboe
2019-04-08 15:19               ` Paolo Valente
2019-04-08 15:14             ` Paolo Valente
2019-04-08 15:17               ` Jens Axboe
2019-04-08 17:01                 ` Paolo Valente
2019-04-10 11:42           ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408143935.9062-1-paolo.valente@linaro.org \
    --to=paolo.valente@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=bfq-iosched@googlegroups.com \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox