From: Johannes Thumshirn <jthumshirn@suse.de>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org, bfq-iosched@googlegroups.com,
oleksandr@natalenko.name,
Angelo Ruocco <angeloruocco90@gmail.com>
Subject: Re: [PATCH 1/1] block, bfq: delete "bfq" prefix from cgroup filenames
Date: Mon, 8 Apr 2019 16:49:25 +0200 [thread overview]
Message-ID: <20190408144925.GA23021@linux-x5ow.site> (raw)
In-Reply-To: <20190408143935.9062-2-paolo.valente@linaro.org>
On Mon, Apr 08, 2019 at 04:39:35PM +0200, Paolo Valente wrote:
> From: Angelo Ruocco <angeloruocco90@gmail.com>
>
> When bfq was merged into mainline, there were two I/O schedulers that
> implemented the proportional-share policy: bfq for blk-mq and cfq for
> legacy blk. bfq's interface files in the blkio/io controller have the
> same names as cfq. But the cgroups interface doesn't allow two
> entities to use the same name for their files, so for bfq we had to
> prepend the "bfq" prefix to each of its files. However no legacy code
> uses these modified file names. This naming also causes confusion, as,
> e.g., in [1].
>
> Now cfq has gone with legacy blk, so there is no need any longer for
> these prefixes in (the never used) bfq names. In view of this fact, this
> commit removes these prefixes, thereby enabling legacy code to truly
> use the proportional share policy in blk-mq.
>
> [1] https://github.com/systemd/systemd/issues/7057
Hmm, but isn't this a user-space facing interface and thus some sort of ABI?
Do you know what's using it and what breaks due to this conversion?
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-04-08 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:39 [PATCH 0/1] bfq: remove prefixes from cgroup filenames Paolo Valente
2019-04-08 14:39 ` [PATCH 1/1] block, bfq: delete "bfq" prefix " Paolo Valente
2019-04-08 14:49 ` Johannes Thumshirn [this message]
2019-04-08 14:54 ` Paolo Valente
2019-04-08 15:01 ` Jens Axboe
2019-04-08 15:04 ` Johannes Thumshirn
2019-04-08 15:05 ` Jens Axboe
2019-04-08 15:06 ` Paolo Valente
2019-04-08 15:11 ` Jens Axboe
2019-04-08 15:15 ` Paolo Valente
2019-04-08 15:08 ` Johannes Thumshirn
2019-04-08 15:13 ` Jens Axboe
2019-04-08 15:19 ` Paolo Valente
2019-04-08 15:14 ` Paolo Valente
2019-04-08 15:17 ` Jens Axboe
2019-04-08 17:01 ` Paolo Valente
2019-04-10 11:42 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2019-09-09 7:31 [PATCH 0/1] block, bfq: remove bfq prefix from cgroups filenames Paolo Valente
2019-09-09 7:31 ` [PATCH 1/1] block, bfq: delete "bfq" prefix from cgroup filenames Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408144925.GA23021@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=angeloruocco90@gmail.com \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox