Linux block layer
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH liburing] spec: additional Fedora RPM cleanups
Date: Fri, 13 Dec 2019 10:16:40 +0000	[thread overview]
Message-ID: <20191213101640.1180590-1-stefanha@redhat.com> (raw)

Cole Robinson made some more suggestions:

 * Use %set_build_flags before ./configure to get the default compiler
   flags.

 * Use '%license COPYING' instead of %doc.

 * Do not ship the static library.  This is distro policy and Fedora
   would ship a separate -static package if static libraries are
   desired.

 * Source: should be the URL to the sources.  URL: should be the URL of
   the website or git repo.

 * The devel package needs
   Requires: %{name}%{?_isa} = %{version}-%{release}

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 liburing.spec | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/liburing.spec b/liburing.spec
index e542771..87b16b1 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -3,8 +3,8 @@ Version: 0.2
 Release: 1%{?dist}
 Summary: Linux-native io_uring I/O access library
 License: LGPLv2+
-Source: %{name}-%{version}.tar.gz
-URL: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+Source: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+URL: https://git.kernel.dk/cgit/liburing/
 BuildRequires: gcc
 
 %description
@@ -13,7 +13,7 @@ manner, for both buffered and O_DIRECT.
 
 %package devel
 Summary: Development files for Linux-native io_uring I/O access library
-Requires: %{name} = %{version}-%{release}
+Requires: %{name}%{_isa} = %{version}-%{release}
 Requires: pkgconfig
 
 %description devel
@@ -24,6 +24,7 @@ for the Linux-native io_uring.
 %autosetup
 
 %build
+%set_build_flags
 ./configure --prefix=%{_prefix} --libdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
 
 %make_build
@@ -33,13 +34,13 @@ for the Linux-native io_uring.
 
 %files
 %attr(0755,root,root) %{_libdir}/liburing.so.*
-%doc COPYING
+%license COPYING
 
 %files devel
 %{_includedir}/liburing/
 %{_includedir}/liburing.h
 %{_libdir}/liburing.so
-%{_libdir}/liburing.a
+%exclude %{_libdir}/liburing.a
 %{_libdir}/pkgconfig/*
 %{_mandir}/man2/*
 
-- 
2.23.0


             reply	other threads:[~2019-12-13 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 10:16 Stefan Hajnoczi [this message]
2019-12-13 15:59 ` [PATCH liburing] spec: additional Fedora RPM cleanups Jeff Moyer
2019-12-18  4:13 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213101640.1180590-1-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox