From: Jens Axboe <axboe@kernel.dk>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: linux-block@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH liburing] spec: additional Fedora RPM cleanups
Date: Tue, 17 Dec 2019 21:13:08 -0700 [thread overview]
Message-ID: <a6da4640-9fba-15c8-dee0-6feb48e66f5a@kernel.dk> (raw)
In-Reply-To: <20191213101640.1180590-1-stefanha@redhat.com>
On 12/13/19 3:16 AM, Stefan Hajnoczi wrote:
> Cole Robinson made some more suggestions:
>
> * Use %set_build_flags before ./configure to get the default compiler
> flags.
>
> * Use '%license COPYING' instead of %doc.
>
> * Do not ship the static library. This is distro policy and Fedora
> would ship a separate -static package if static libraries are
> desired.
>
> * Source: should be the URL to the sources. URL: should be the URL of
> the website or git repo.
>
> * The devel package needs
> Requires: %{name}%{?_isa} = %{version}-%{release}
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-12-18 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 10:16 [PATCH liburing] spec: additional Fedora RPM cleanups Stefan Hajnoczi
2019-12-13 15:59 ` Jeff Moyer
2019-12-18 4:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6da4640-9fba-15c8-dee0-6feb48e66f5a@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox