public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Jens Axboe <axboe@kernel.dk>, "Ming Lei" <ming.lei@redhat.com>
Cc: Hulk Robot <hulkci@huawei.com>, <linux-block@vger.kernel.org>
Subject: [PATCH -next] block: remove unused but set variable 'hctx'
Date: Thu, 2 Jul 2020 11:54:45 +0800	[thread overview]
Message-ID: <20200702035445.22780-1-weiyongjun1@huawei.com> (raw)

From: Hulk Robot <hulkci@huawei.com>

After commit 37f4a24c2469 ("blk-mq: centralise related handling
into blk_mq_get_driver_tag"), 'hctx' is never be used. Gcc report
build warning:

block/blk-flush.c:222:24: warning:
 variable hctx set but not used [-Wunused-but-set-variable]
  222 |  struct blk_mq_hw_ctx *hctx;
      |                        ^~~~

Just removing it to avoid build warning.

Signed-off-by: Hulk Robot <hulkci@huawei.com>
---
 block/blk-flush.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/blk-flush.c b/block/blk-flush.c
index e756db088d84..a20fe125e9fa 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -219,7 +219,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error)
 	struct request *rq, *n;
 	unsigned long flags = 0;
 	struct blk_flush_queue *fq = blk_get_flush_queue(q, flush_rq->mq_ctx);
-	struct blk_mq_hw_ctx *hctx;
 
 	blk_account_io_flush(flush_rq);
 
@@ -235,7 +234,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error)
 	if (fq->rq_status != BLK_STS_OK)
 		error = fq->rq_status;
 
-	hctx = flush_rq->mq_hctx;
 	if (!q->elevator)
 		flush_rq->tag = BLK_MQ_NO_TAG;
 	else


             reply	other threads:[~2020-07-02  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  3:54 Wei Yongjun [this message]
2020-07-02  4:34 ` [PATCH -next] block: remove unused but set variable 'hctx' Chaitanya Kulkarni
2020-07-02  4:36 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702035445.22780-1-weiyongjun1@huawei.com \
    --to=weiyongjun1@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=hulkci@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox