From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>
Cc: Hulk Robot <hulkci@huawei.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH -next] block: remove unused but set variable 'hctx'
Date: Thu, 2 Jul 2020 04:34:59 +0000 [thread overview]
Message-ID: <BYAPR04MB49654DBF16059D009ADBDA4D866D0@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200702035445.22780-1-weiyongjun1@huawei.com
On 7/1/20 8:44 PM, Wei Yongjun wrote:
> From: Hulk Robot<hulkci@huawei.com>
>
> After commit 37f4a24c2469 ("blk-mq: centralise related handling
> into blk_mq_get_driver_tag"), 'hctx' is never be used. Gcc report
> build warning:
>
> block/blk-flush.c:222:24: warning:
> variable hctx set but not used [-Wunused-but-set-variable]
> 222 | struct blk_mq_hw_ctx *hctx;
> | ^~~~
>
> Just removing it to avoid build warning.
Ha Ha was about to send this patch.
Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2020-07-02 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 3:54 [PATCH -next] block: remove unused but set variable 'hctx' Wei Yongjun
2020-07-02 4:34 ` Chaitanya Kulkarni [this message]
2020-07-02 4:36 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB49654DBF16059D009ADBDA4D866D0@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hulkci@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox