From: kernel test robot <lkp@intel.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, axboe@kernel.dk
Cc: kbuild-all@lists.01.org, ming.lei@redhat.com, hch@lst.de,
baolin.wang@linux.alibaba.com, baolin.wang7@gmail.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] block: fix boolconv.cocci warnings
Date: Mon, 17 Aug 2020 15:55:59 +0800 [thread overview]
Message-ID: <20200817075559.GA149398@7edacc24721b> (raw)
In-Reply-To: <5b932aa51fc2b46c381d7b83d591a6ddbf05b199.1597637287.git.baolin.wang@linux.alibaba.com>
From: kernel test robot <lkp@intel.com>
block/blk-mq-sched.c:404:39-44: WARNING: conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
CC: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Some-clean-ups-for-bio-merge/20200817-121114
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
Please take the patch only if it's a positive warning. Thanks!
blk-mq-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -401,7 +401,7 @@ bool blk_mq_bio_list_merge(struct reques
if (merge == BIO_MERGE_NONE)
continue;
- return merge == BIO_MERGE_OK ? true: false;
+ return merge == BIO_MERGE_OK;
}
return false;
next prev parent reply other threads:[~2020-08-17 7:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 4:09 [PATCH RESEND 0/5] Some clean-ups for bio merge Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 1/5] block: Move bio merge related functions into blk-merge.c Baolin Wang
2020-08-17 6:15 ` Christoph Hellwig
2020-08-17 4:09 ` [PATCH RESEND 2/5] block: Remove redundant blk_mq_sched_allow_merge() validation Baolin Wang
2020-08-17 6:22 ` Christoph Hellwig
2020-08-17 12:06 ` Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio Baolin Wang
2020-08-17 6:26 ` Christoph Hellwig
2020-08-17 12:10 ` Baolin Wang
2020-08-17 12:24 ` Christoph Hellwig
2020-08-18 3:30 ` Baolin Wang
2020-08-17 7:55 ` kernel test robot [this message]
2020-08-17 7:55 ` kernel test robot
2020-08-17 4:09 ` [PATCH RESEND 4/5] block: Remove blk_mq_attempt_merge() function Baolin Wang
2020-08-17 6:31 ` Christoph Hellwig
2020-08-17 12:10 ` Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper Baolin Wang
2020-08-17 6:32 ` Christoph Hellwig
2020-08-17 12:14 ` Baolin Wang
2020-08-17 12:26 ` Christoph Hellwig
2020-08-18 3:29 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817075559.GA149398@7edacc24721b \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox