Linux block layer
 help / color / mirror / Atom feed
* [PATCH] block: fix the kerneldoc comment for __register_blkdev
@ 2020-11-14 17:08 Christoph Hellwig
  2020-11-14 17:33 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2020-11-14 17:08 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, Stephen Rothwell

Switch the comment to talk about __register_blkdev instead of
register_blkdev and document the new probe parameter.

Fixes: 3da1a61e7046 ("block: add an optional probe callback to major_names")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/genhd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/block/genhd.c b/block/genhd.c
index 15b90e56a1a6ea..e7b7cae30f7f85 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -415,11 +415,12 @@ void blkdev_show(struct seq_file *seqf, off_t offset)
 #endif /* CONFIG_PROC_FS */
 
 /**
- * register_blkdev - register a new block device
+ * __register_blkdev - register a new block device
  *
  * @major: the requested major device number [1..BLKDEV_MAJOR_MAX-1]. If
  *         @major = 0, try to allocate any unused major number.
  * @name: the name of the new block device as a zero terminated string
+ * @probe: allback that is called on access to any minor number of @major
  *
  * The @name must be unique within the system.
  *
@@ -433,6 +434,8 @@ void blkdev_show(struct seq_file *seqf, off_t offset)
  *
  * See Documentation/admin-guide/devices.txt for the list of allocated
  * major numbers.
+ *
+ * Use register_blkdev instead for any new code.
  */
 int __register_blkdev(unsigned int major, const char *name,
 		void (*probe)(dev_t devt))
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: fix the kerneldoc comment for __register_blkdev
  2020-11-14 17:08 [PATCH] block: fix the kerneldoc comment for __register_blkdev Christoph Hellwig
@ 2020-11-14 17:33 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-11-14 17:33 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-block, Stephen Rothwell

On 11/14/20 10:08 AM, Christoph Hellwig wrote:
> Switch the comment to talk about __register_blkdev instead of
> register_blkdev and document the new probe parameter.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-14 17:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-14 17:08 [PATCH] block: fix the kerneldoc comment for __register_blkdev Christoph Hellwig
2020-11-14 17:33 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox